Mahara

SAML metadata screen titled IdP when it should be SP

Bug #1827955 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 19.10.0
18.04
Fix Released
Medium
Unassigned
Mahara 18.04.5
18.10
Fix Released
Medium
Unassigned
Mahara 18.10.2
19.04
Fix Released
Medium
Unassigned
Mahara 19.04.1
19.10
Fix Released
Medium
Unassigned
Mahara 19.10.0

Bug Description

We need to use the correct title - the same one used in the default metadata.php file

It can be seen at htdocs/auth/saml/extlib/simplesamlphp/modules/saml/www/sp/metadata.php when ssphp is installed

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9964

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test:

1) Go to the Administration -> Extensions -> Plugin admin page
2) Click the configure 'cog' for SAML
3) Follow the 'View metadata' link

The title of that page should be "SAML 2.0 SP Metadata"

Changed in mahara:
status: New → In Progress
milestone: none → 19.10.0
importance: Undecided → Medium
Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 0aa442647a05d83422312d91d5549ecb45b9c0a8
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) n/a

TEST STEPS:
------------------------
1) Go to the Administration -> Extensions -> Plugin admin page
2) Click the configure 'cog' for SAML
3) Follow the 'View metadata' link
4) Verify the title of that page should be "SAML 2.0 SP Metadata" ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9964
Committed: https://git.mahara.org/mahara/mahara/commit/0aa442647a05d83422312d91d5549ecb45b9c0a8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0aa442647a05d83422312d91d5549ecb45b9c0a8
Author: Robert Lyon <email address hidden>
Date: Tue May 7 10:40:22 2019 +1200

Bug 1827955: display correct header on SAML metadata page

Behatnotneeded

Change-Id: Id4a2e64ae970dad25065ca38bc98de0a268c1c17
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9965

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9965
Committed: https://git.mahara.org/mahara/mahara/commit/8da7dfe13257f4f76566abea6a4e28a89c4c3334
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 8da7dfe13257f4f76566abea6a4e28a89c4c3334
Author: Robert Lyon <email address hidden>
Date: Tue May 7 10:40:22 2019 +1200

Bug 1827955: display correct header on SAML metadata page

Behatnotneeded

Change-Id: Id4a2e64ae970dad25065ca38bc98de0a268c1c17
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0aa442647a05d83422312d91d5549ecb45b9c0a8)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9966

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9966
Committed: https://git.mahara.org/mahara/mahara/commit/758ffe5a69a0923701005e9ac4a21e6baddb8c40
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 758ffe5a69a0923701005e9ac4a21e6baddb8c40
Author: Robert Lyon <email address hidden>
Date: Tue May 7 10:40:22 2019 +1200

Bug 1827955: display correct header on SAML metadata page

Behatnotneeded

Change-Id: Id4a2e64ae970dad25065ca38bc98de0a268c1c17
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0aa442647a05d83422312d91d5549ecb45b9c0a8)
(cherry picked from commit 8da7dfe13257f4f76566abea6a4e28a89c4c3334)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9967

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9967
Committed: https://git.mahara.org/mahara/mahara/commit/9369cd84a67b7a8706a560d8de55eaaf70e7c8ce
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 9369cd84a67b7a8706a560d8de55eaaf70e7c8ce
Author: Robert Lyon <email address hidden>
Date: Tue May 7 10:40:22 2019 +1200

Bug 1827955: display correct header on SAML metadata page

Behatnotneeded

Change-Id: Id4a2e64ae970dad25065ca38bc98de0a268c1c17
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0aa442647a05d83422312d91d5549ecb45b9c0a8)
(cherry picked from commit 8da7dfe13257f4f76566abea6a4e28a89c4c3334)
(cherry picked from commit 758ffe5a69a0923701005e9ac4a21e6baddb8c40)

Kristina Hoeppner (kris-hoeppner)
tags: added: usermanualupdate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.