Move "Add comment" and "Details" into modal with "Comments"

Bug #1827811 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Lisa Seeto

Bug Description

This is part of the page revamp: https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

Currently, the "Add comment" and "Details" links at blocks that can have them, takes you to a separate page where you can view the artefact's metadata and can leave comments.

When you view comments, they are already displayed in the modal directly on the page, but you can't leave a comment yet.

The things to be done:

- Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
- Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

This would also mean to review all the "Details" on blocks as some of them are not needed. For example, clicking the details link next to a plan task only shows that single plan task again without any additional details. The "Details" should only be there when there is additional metadata information but not simply repeating the block content.

The title of the modal (the one in the green bar) would be the blocktype as the title of the block is listed below.

A decision still needs to be made on whether comments can be paginated in the modal or if they are shown all one after another (which might get quite long).

We are not changing anything else from the proposal as that requires Gridstack to be implemented first. This is a standalone usability improvement independent of Gridstack.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10061

Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10102

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10107

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10125

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10129

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10131

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10157

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10162

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10189

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10204

Revision history for this message
Steven (stevens-q) wrote :
Download full text (12.6 KiB)

Commit hash: 013743dffc98b806474c4b9065c34bc21c329147
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara User1 exists and has a portfolio page "1 Column Layout - (Comments testing)" and it is public and able to be copied
2) Portfolio page has the following blocks:
 a) Image
 b) File(s) to download
 c) Folder
 d) Journal
 e) Journal entry
 f) Recent journal entries
 g) Tagged journal entries
 h) Plans
 i) Notes (with tags)
 j) My entire resume
 k) One resume field
3) User1's resume section is completely filled in with attachments where applicable.
4) Journal exists with Journal entries which have attached files and comments are allowed
5) Site has licenced meta data turned on (admin menu > Configure site > Site options > General)
6) Mahara User3 exists (No Roles)

TEST STEPS: note the idea is that the comments and details are displayed in the flyout modal area
------------------------

Image block:
1) Log in as Mahara User3
2) Browse to User1' s portfolio page as mentioned above
3) Verify the image block has the following:
 - Image displays and is a link that opens the modal ✔
 - Link under the image opens the modal: ✔
 - [icon] Comments (current number of comments) and details ✔
4) Click the link to make a comment
5) Verify that the modal opens and has the following
 - preview image that is a link to download the image ✔
 - metadata ✔
 - comments (if any) ✔
 - Add comment form ✔
6) Make a comment and attach a file to it
7) Verify the comment displays in comment area with download link inside the flyout modal ✔

File(s) to download:
1) Log in as Mahara User3
2) Browse to User1' s portfolio page as mentioned above
3) Verify the files to download block has the following
 - Each file title is a link that opens the modal. Hovering over the row gives the option to download the file. ✔
4) Click a file title
5) Verify that the fly out modal has the following:
   a) For image files:
  - preview image that is a link to download the image ✔
  - metadata with download button ✔
  - comments (if any) ✔
  - Add comment form ✔
   b) For other files:
  -metadata with download button ✔
6) Verify that attachments can be attached as a comment when there is an add comment form, displays in comment area with download link

Folder:
1) Log in as Mahara User3
2) Browse to User1' s portfolio page as mentioned above
3) Verify that the folder block has the following:
   a) The details link no longer appears ✔
   b) Each file title is a link that opens the modal. Hovering over the row gives the option to download the file ✔
4) Click the file title of the file you want to make a comment for or view details
5) Verify that the folder block has the following
   a) For image files:
   - preview image that is a link to download the image ✔
   - metadata with download button ✔
   - comments (if any) ✔
    - Add comment form ✔
   b) For other files:
  -metadata with download button ✔
6) Verify that attachments can be attached as a comment when there is an add comment form, displays in comment area with download link ✔

NOTE: to view the flyout modal user must click on the title - clicking anywh...

Revision history for this message
Steven (stevens-q) wrote :

BUG #1 User can make a comment without entering text in the comment field
**************
#1 (Chrome)
When a user clicks comment button without entering a comment, an error message is displayed. However it is only for a few seconds before the modal appears to reopen and the error message is hidden. ✘

#2 (Firefox)
When a user clicks comment button without entering a comment, an error message is displayed.
However the error message is displayed on the main page under the modal and a second error message is displayed just under the Add comment (WISIWIG) comment field. This is inconsistent with the rest of the site. ✘

**************************
**************************

Bug #2 Accessibility issue - User cannot navigate to modal window using keyboard only naviigation
**************

Bug Has been fixed and user can now navigate to the modal and close the modal if they wish. ✔

Revision history for this message
Lisa Seeto (lisaseeto) wrote :

Hi Steven,
I can not reproduce issues #1 or #2 from your last comment (#13). Are there any extra steps I am missing?

Revision history for this message
Steven (stevens-q) wrote :

Bug #1 Fixed - BUG #1 When a user tries to make a comment without adding text into the "Add comment" text area an error message is displayed at the top of the modal window and also just below the "Add comment" field

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10283

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10285

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10299

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10302

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10304

Revision history for this message
Rangi Daymond (rangid) wrote :
Download full text (4.2 KiB)

Patchset: https://reviews.mahara.org/#/c/10304/6
Browser tested: Firefox
Theme used: Raw

*PRECONDITIONS:
----------------
1) Logged in (non administrative) user1 has a newly created portfolio with:
   a) at least two Journals with several Journal entries in each with a couple of shared tags across them and at least one entry with a long title
   b) a page that contains the following (populated) blocks:
      1.1 Embedded media
      1.2 Image
      1.3 Image gallery
      1.4 PDF
      1.5 Some HTML
      1.6 Note
      1.7 Journal
      1.8 Recent journal entries
      1.9 Tagged journal entries --> ensure to select the option 'Show journal entries in full' ie set to Yes

2) The portfolio/page is shared with at least one other non administrative user (user2)

*TEST STEPS:
-------------
Step 1) As logged in user1, display the target portfolio/page then select the page 'Details' button (above the 'Edit' button, near top on right)
Step 2) Check the styling, positioning and functionality of the various block comment & detail bars/icons

***ISSUE1:
----------
Expected results: The styling and positioning of the various block comment & detail bars/icons are as follows:
   1.1 Embedded media (bar - details only, positioned at top of block) X
   1.2 Image (bar - details and comments, positioned at top of block) ✓
   1.3 Image gallery (bar - details only, positioned at top of block) X
   1.4 PDF (bar - details and comments, positioned at top of block) X
   1.5 Some HTML (bar - details only, positioned at top of block) X
   1.6 Note (bar - details and comments, positioned at top of block) ✓
   1.7 Journal with 1+ Journal entries --> one per entry (icons - details and comments, positioned on top right of entry title) ✓
   1.8 Recent journal entries --> one each entry (icons - details and comments, positioned on top right of entry title) ✓
   1.9 Tagged journal entries --> one each entry (icons - details and comments, positioned on top right of entry title) X
        --> the entry item styling should be as per the Recent journal entry styling X
   2.0 Long titles of blocks that use comment and/or detail icons should be readable X

Actual results: please see attached annotated screenshots (filenames prefixed with SS1 & SS2-1, SS2-2 & SS2-3), as expected above except for:
   1.1 Embedded media, 1.3 Image Gallery & 1.5 Some HTML: the bar position is incorrect (under instead of above the title when present), see SS1
   1.4 PDF should be a bar (not icons) positioned at the top of the block, see SS1
   1.9 Tagged journal entries should each have comment (if user selected) and/or detail icons to the right of their (wrapped if necessary) title, see SS2-1, SS2-2 & SS2-3. The entry item styling is not as per the Recent journal entry styling, see SS2-1
   2.0 Jounal entries with long titles are partially covered by the comment and/or detail icon/s, see SS2-1.

***ISSUE2:
----------
Step 3) Scroll to view the PDF block and click on the comment icon and add a Comment
Expected results: the comment icon should update to include an incremented comment count value eg from none to 1, 1 to 2 etc. and when the user refres...

Read more...

Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Rangi Daymond (rangid) wrote :

Patchset: https://reviews.mahara.org/#/c/10304/6
Browser tested: Firefox
Theme used: Raw

TEST SCENARIO: Verify that exported HTML portfolio/pages with image blocks that have Comments and/or Details can be viewed as expected.
--------------

*PRECONDITIONS:
---------------
1) Logged in (non administrative) user1 has a newly created HTML export of a portfolio/page with at least two image blocks (one commented upon - public and private ones - and one not) and one folder block (that contains the image/s used in the image blocks).

2) The portfolio/page is shared with at least one other non administrative user (user2) who has also commented (some private and some public) on the block with prior comments.

3) The portfolio/page is exported as HTML with comments option selected, and the downloaded file unzipped and the index.html file is opened in the browser

**TEST STEPS:
-------------
Verify that the portfolio/page content displays as expected with special focus on the block comments and details.

Step 1. Open the index.html file to view the exported material.
Step 2. Click on the image block's image to view the details and comments.

**Image block HTML export bug: the image block details and comments are not accessible via the image block but they are via the folder block file - please see the attachments (with prefix SS1 shows the console error when the user attempts to click the image in the image block, with prefix SS2 shows the details and comments displayed when user clicks the folder block's image filename).

Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10355

Revision history for this message
Rangi Daymond (rangid) wrote :
Download full text (4.8 KiB)

Gerrit/Patchset: https://reviews.mahara.org/#/c/10355/2
Browser tested: Firefox only at present
Theme used: Raw

*PRECONDITIONS:
----------------
1) Logged in (non administrative) user1 has a recently created portfolio/page with:
   a) at least two Journals with several Journal entries in each with a couple of shared tags across them and at least one entry with a long title
   b) a page that contains the following (populated) blocks:
      1.1 Embedded media
      1.2 Image
      1.3 Image gallery
      1.4 PDF
      1.5 Some HTML
      1.6 Note
      1.7 Journal
      1.8 Recent journal entries
      1.9 Tagged journal entries --> ensure to select the option 'Show journal entries in full' ie set to Yes
      1.10 Long block titles that use comment and/or detail icons should be readable
      1.11 File/s to download
      1.12 Folder

2) The portfolio/page is shared with at least one other non administrative user (user2)

*TEST STEPS:
-------------
Step A) In each browser, log in as user1 then user2, display the target portfolio/page then select the page 'Details' button (above the 'Edit' button, near top on right)
Step B) Check the styling, positioning and functionality of the various block comment & detail bars/icons

Expected & Actual results: The styling and positioning of the various block comment & detail bars/icons are as follows:
   1.1 Embedded media (bar - details and comments, positioned at top of block) click bar for modal ✓
   1.2 Image (bar - details and comments, positioned at top of block) click bar or image for modal ✓
   1.3 Image gallery (bar - details only, positioned at top of block) click bar for modal or
                                  click an image for slideshow OR image modal - see issue 1 below X
   1.4 PDF (bar - details and comments, positioned at top of block) click bar for modal ✓
   1.5 Some HTML (bar - details only, positioned at top of block) click bar for modal ✓
   1.6 Note (bar - details and comments, positioned at top of block) click bar for modal ✓
   1.7 Journal with 1+ Journal entries --> one per entry (icons - details and comments, positioned on top right of entry title)
          click journal entry title or icon for modal - minor problem see Issue 2 below X
   1.8 Recent journal entries --> one each entry (icons - details and comments, positioned on top right of entry title)
                                             click journal entry title or icon for modal ✓
   1.9 Tagged journal entries --> one each entry (icons - details and comments, positioned on top right of entry title)
                                             click journal entry title or icon for modal ✓
   1.10 Long titles of blocks that use comment and/or detail icons should be readable ✓
   1.11 File/s to download --> one each entry (icons - details and comments, positioned on top right of entry title)
               click download to download or select the filename title or icon for modal ✓
   1.12 Folder --> sub-folder entry/ies (details icon only, positioned on top right of entry title)
          click folder name or details icon for modal displaying folder content - see issue 3 below X
               --> filenam...

Read more...

Revision history for this message
Rangi Daymond (rangid) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10304
Committed: https://git.mahara.org/mahara/mahara/commit/953a5eab46711322c071b7f4b25bf7431b14a4ed
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 953a5eab46711322c071b7f4b25bf7431b14a4ed
Author: Lisa Seeto <email address hidden>
Date: Fri Sep 6 14:25:29 2019 +1200

Bug 1827811: Resume Icons

- get attachment comment counts for bh icons
- display plain text for titles in editing mode
- change the way the commentlink is targetted via js
- add blockid's to resume attachments
- for folder block: add comment count, change titles from
 links to plain text when editing
- change notes attachment file titles from links to plain
 text when editing
- get rid of the single artefact block title links for html exports
---------------------------------------------------------
Add fixes:
- blocks that have set types but no artefacts attached don't have modal links
- pdf block is now using block header and comment count is loaded
- block headers are above titles
- tagged journals have icons when in full and matches recent posts styling
- deleting all comments produces correct icon on block header
- html exports should not hang on opening modal
- get rid of warning error re: dock.show() when redirecting from &modal=1 style url
- code review fixes for all previous patches + fix issue with folders block
- added in viewdetailsfilter.json.php file to save details mode to user account prefs table
- make the details btn mode "sticky" so it stays the save value over multiple pages etc...
- Image Gallery blocks: if displaying a folder of images will get the bar block header and
will have a the fancy box image preview displaying on image click

Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10285
Committed: https://git.mahara.org/mahara/mahara/commit/b82df03d4b572aeaebdc690dccc634f953957d31
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b82df03d4b572aeaebdc690dccc634f953957d31
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 3 18:01:12 2019 +1200

Bug 1827811: Embedded Media Task

add the block-header to the block.
remove the download link from page as it now shows in the modal.
add artefactid and blockid to image.tpl
fix issue with data-toggle collapse targeting syntax error.
update active block functionality for block headers
update block-comments-details-header.tpl for icon headers
fix Journals, and tagged entries and recent posts to use icons for block header.
change pdf block to use block header icons
clean up .comments-details class that is no longer needed.
add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
add modal functionality for some html block, clear up js for icons that is no longer needed.
add title text to icons and block-header
create activateModalLinks() func to tidy up js modal click events in view/view.php

Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10157
Committed: https://git.mahara.org/mahara/mahara/commit/e6b6ecf9186d0f2bd9137da3ee5af105595126c9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit e6b6ecf9186d0f2bd9137da3ee5af105595126c9
Author: Lisa Seeto <email address hidden>
Date: Fri Jul 12 11:32:07 2019 +1200

Bug 1827811: Exports task

This change creates the modals for exported html pages.
Modals are hard-coded onto page with id's of modal_[artefactid]
Bootstrap and jquery files are copied into export js folder.
Profile page is also exported with any modal content.
Add tagged posts modals
get rid of export warning when no $commentcount set in viewposts.tpl
Add recent posts modals so that first journal post was also a modal
Set Parent journal link text to plain text for exports
Add entire resume modals and one resume field modals
Add File(s) to download modals
refactor export_artefact_metadata_modals
add metadata but not comments to resume page
add metata (license info) but not comments to journal pages
add comment count default to 0 in .tpl's if comment count not present (during export)
remove updating comments modals for profile page as this is no longer needed.

Change-Id: Iff50138285951a4f9a1573423f4f74feba97886f
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10204
Committed: https://git.mahara.org/mahara/mahara/commit/79201b7d8a132a0b6f95a95f8e1ebfda71f092be
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 79201b7d8a132a0b6f95a95f8e1ebfda71f092be
Author: Lisa Seeto <email address hidden>
Date: Mon Jul 22 14:37:46 2019 +1200

Bug 1827811: Redirects

This change cleans up the last of the redirects to artefact/artefact.php
Update the links for the journal and journal entries for elasticsearch to go to blog
Update the links for the journal and journal entries in consideration of new reqs
Update artefact/artefact with session msg + access denied error

Change-Id: Ied34542632bd4e49a353ec17937d685614117643
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10299
Committed: https://git.mahara.org/mahara/mahara/commit/fb47b83103355158ec0646f8cc4d38b7408562f4
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fb47b83103355158ec0646f8cc4d38b7408562f4
Author: Lisa Seeto <email address hidden>
Date: Fri Sep 6 09:34:52 2019 +1200

Bug 1827811: UI Task

The change is for making sure the styling is working for the blocks.

* make file(s) to download use bh icons, metadata on new line
* resume attachments to use icons (buggy but apparently necessary)
* show file(s) to download titles on hover over link
* get rid of '-' for file metadata for size etc...
* fix the editing/display descrepancy of tagged/recent posts titles

Change-Id: Iad7bb30944f5924b43eca96993e3334120076c05
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10283
Committed: https://git.mahara.org/mahara/mahara/commit/44fcc9c9f72e7a6a3605b795ec0365eafd5a6d0a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 44fcc9c9f72e7a6a3605b795ec0365eafd5a6d0a
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 3 15:51:32 2019 +1200

Bug 1827811: Folder Task

This change adds modal functionality for folders and nested folders
add javascript to the folder_render_self template.
add new class to make space between icon and title/ metadata in modals
fix blockid warning message error
added folder_render_in_modal.tpl to fix duplicate js script issues interferring with js events
creaeted toggleDetailsBtn() to handle js issues
get rid of old style comments link from showing up.
turn off click functions so json sendrequest doesn't call a billion times.
explicitly call dock.show() in the open_modal func.

Change-Id: I938f98c33479a80afc8f940038ed81a3c84ce4ff
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10302
Committed: https://git.mahara.org/mahara/mahara/commit/f8d9ec0a78363bcdab63a85aabbc735ed86badcf
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f8d9ec0a78363bcdab63a85aabbc735ed86badcf
Author: Evonne <email address hidden>
Date: Fri Sep 6 10:58:28 2019 +1200

Bug 1827811: UI Task theming

Fixing alignments and hover/active states for assessment buttons.

behatnotneeded

Change-Id: I8774ecc53d5d3744f1e4e0b6debf2e6476e71ce8

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10189
Committed: https://git.mahara.org/mahara/mahara/commit/1885a18de3123509a4471de9ed1c680418be0de0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 1885a18de3123509a4471de9ed1c680418be0de0
Author: Lisa Seeto <email address hidden>
Date: Fri Jul 19 11:11:10 2019 +1200

Bug 1827811: Notes block

do not show note contents when displayed in a modal.
if comments not allowed but license metadata is on, display details link and open model with license data.
make small change to setting of licensemetadata smarty variable
get rid of comments/details links and use the new block header instead.

Change-Id: I9183292278d06a3766ae08b0376237fda8d7206c
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10102
Committed: https://git.mahara.org/mahara/mahara/commit/f7431a3a3034f5822727f0ab217d1dd9736beeaf
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f7431a3a3034f5822727f0ab217d1dd9736beeaf
Author: Lisa Seeto <email address hidden>
Date: Wed Jun 19 13:28:07 2019 +1200

Bug 1827811: Journal changes

Journal changes:
Change the modal contents to not show post contents or attached files.
Recent posts and Tagged posts (if not in full display) now expandable with post contents and comment links.
Attached files on page block now links only to download and not to display further metadata.
Cleaned up artefact.php links.
remove metada that will show on entry on page from also showing in modal
stop background page scrolling when the modal is opened and "Advanced licensing" is selected.
add the blogpost_render_in_modal.tpl file
get rid of scrolling for data-toggle collapse
add block-header to journal, journal entry
add titles as modal links for recent posts and tagged journal entries
add comments and details icons for recent posts and tagged journal entries
fix things from code review

behatnotneeded

Change-Id: Ic63ebf9fe42e7848559b5e009584fdff0a40770f
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10162
Committed: https://git.mahara.org/mahara/mahara/commit/8df0061e76191227e27da29e50c8edf62f0ffa24
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 8df0061e76191227e27da29e50c8edf62f0ffa24
Author: Lisa Seeto <email address hidden>
Date: Tue Jul 16 16:53:49 2019 +1200

Bug 1827811: Resume changes

added the modal_link for resume field attachments
fixed the modal)link typo in employmenthistory template
update commentlink to modal_link for goals and skills template

Change-Id: I8b203628dc47d7019ee75165cb11bc392ddefa03
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10107
Committed: https://git.mahara.org/mahara/mahara/commit/ece65af480bf5186e8738f0b3f3542d7f220cd0e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit ece65af480bf5186e8738f0b3f3542d7f220cd0e
Author: Lisa Seeto <email address hidden>
Date: Wed Jun 19 17:01:20 2019 +1200

Bug 1827811: Plans block

behatnotneeded

The plan block's 'details' link will only display if license metadata is available.
The link will open the modal with licensing information.
Update how the licensemetadata is set in smarty variable.
remove old details link and use new block header instead.
remove the use of modal functionality, block headers & smarty vars

Change-Id: I5f06d9ba84ff018a50ba774763be3fcede9b2576
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10061
Committed: https://git.mahara.org/mahara/mahara/commit/be7af61faa0f8cae4ccf72b53d29a10885ae1746
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit be7af61faa0f8cae4ccf72b53d29a10885ae1746
Author: Lisa Seeto <email address hidden>
Date: Thu May 30 11:07:14 2019 +1200

Bug 1827811: Move "Add comment" and "Details" into modal with "Comments"

create modal using configureblock id, update various templates to use the modal for blocks:
Image
Note
File(s) to download
Journal/blogs
add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
add JS to handle url that redirects to view/view.php with modal open and populated.
Further changes to each block will be completed in child patches.
Add segment headings to the modal. Fix display of comments to cover width of modal.
Show comment removed msg in modal/page appropriately.
Fix behat test to close modal before continuing.
do not show existing comments if comments not allowed on artefact.
add validation to modal for comments/attachments
disable image as link when editing for image block
trigger focus on modal for accessibility
close modal on escape keydown event
fix merge conflict in view/view.php
fix merge conflict with master
make configureblock modal play nicely when comment block is on the page
update display of error messages to always show at top of modal so user doesn't have to scroll
add accesibility to close modal on escape key down
handle dock show/hide events for paginated pages in modal during validation
create block-comments-details-header template file
create details button and custom scss file with js to show and hide header
update comment links to save add comment and details when commentcount == 0
add active-block class to colour the block-header when active
toggle the details-btn active css
add _block-comments-details-header.scss to patch
change class invisble to class d-none
add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
code review changes
add .no-modal class to links on group home page, dashboard and profile page.
add block header to appear above the title
change assessbtn from anchor tag to button to prevent scrolling.
make all clickable links clickable on page load (ignore assess mode)
fix js issues surrounding assessbtn move and show/hide blocks
change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
update assessbtn to details btn
create tooltip for hover over file download block titles
fix containerElm console log error by not reattaching tinymce unneccessarily.
fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.

Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10382

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10355
Committed: https://git.mahara.org/mahara/mahara/commit/f5ca6b3aa22a682e9596ea20539f96a6ef3f8cab
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f5ca6b3aa22a682e9596ea20539f96a6ef3f8cab
Author: Evonne <email address hidden>
Date: Wed Sep 18 15:09:27 2019 +1200

Bug 1827811: Journal and resume details buttons overlap

Fixes for journal titles and resume attachments for employment
overlapped by details button.

behatnotneeded

- clean up unneccessary include in export/html/lib.php
- fix html export for the creation of nested folder modals
make sure the nested folders and find all nested modals
- fix elseif typo in block-comments-details-header.tpl
- add details bar to image gallery when displayed from folders
- fix notes block empty modal issue due to .tpl typo
- fix image gallery slideshow error where second gallery block
always targets the first
- keep the active block headers showing after pagination update

Change-Id: Icf8d59ad558d74883e3ee2070f55768697af4254

Revision history for this message
Rangi Daymond (rangid) wrote :

**Gerrit/Patchset: https://reviews.mahara.org/mahara refs/changes/55/10355/11
**Browser tested: Firefox
**Theme used: Default (Raw)

**DESCRIPTION/SUMMARY:
Fixes for journal titles and resume attachments for employment/education overlapped by details button.

**PRECONDITIONS:
1. Logged in user has a portfolio/page that includes:
a) journal blocks (3 types) and journal entries with long titles, and,
b) a resume that includes Education and Employment entries each with attachments with long names

**TEST STEPS:
Step1: Logged in user navigates to their portfolio/page and views each of the following blocks' details and comments modals:
1.1 Journal entries
1.2 Recent journal entries
1.3 Tagged journal entries
2.1 Resume Education entry with one or more attachments
2.2 Resume Employment entry with one or more attachments

Expected result: The entry artefact's name/title is clearly displayed (ie not partially obscured by the Details/Comments icons)
Actual result: As expected (see Resume attachment examples) ✔ Catalyst QA

Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers