Adding / viewing a PDF has pdf menus open by default

Bug #1827797 reported by Robert Lyon on 2019-05-05
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned

Bug Description

On 19.04+ When I add a PDF to a page it displays with the PDF menus open.

This didn't use to happen.

Need to change it so the menus are closed on default

Steven (stevens-q) wrote :

Commit hash: 9bf5ee03304c2fd228695b565b40778e268247b5
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Mahara user exists
2) portfolio page exist as follows
  a) has a pdf block with pfd

TEST STEPS:
------------------------
1) Log in as Mahara user
2) View the displayed portfolio page that has the PDF block
3) Verify that the PDF menus are NOT open ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9957
Committed: https://git.mahara.org/mahara/mahara/commit/9bf5ee03304c2fd228695b565b40778e268247b5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 9bf5ee03304c2fd228695b565b40778e268247b5
Author: Robert Lyon <email address hidden>
Date: Mon May 6 08:47:13 2019 +1200

Bug 1827797: PDF viewer not hiding submenus on loading

This is due to the PDFjs using it's own .hidden css
and we changed 'hidden' class to 'd-none' in the html.
We need to change it back to 'hidden' again.

behatnotneeded

Change-Id: I91fd9dbd890d1e0effa98f667461fc49b24dc154
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/10009
Committed: https://git.mahara.org/mahara/mahara/commit/22a89c940dd1cb2d230898b0a17c75f831b6c435
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 22a89c940dd1cb2d230898b0a17c75f831b6c435
Author: Robert Lyon <email address hidden>
Date: Mon May 6 08:47:13 2019 +1200

Bug 1827797: PDF viewer not hiding submenus on loading

This is due to the PDFjs using it's own .hidden css
and we changed 'hidden' class to 'd-none' in the html.
We need to change it back to 'hidden' again.

behatnotneeded

Change-Id: I91fd9dbd890d1e0effa98f667461fc49b24dc154
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9bf5ee03304c2fd228695b565b40778e268247b5)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers