Deleting non-institutional tag from file produces a warning

[Lisa Seeto]

Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached).

To replicate:
1/ Upload a file
2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes
4/ Edit the file again and delete the tag, Save changes
5/ Refresh the page

Expected result:
No warnings are displayed

Actual result:
Warning is displayed

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9921

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9921
Committed: https://git.mahara.org/mahara/mahara/commit/9cfe3bb987c4bc270ec865f1e6f84a12246d26bf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9cfe3bb987c4bc270ec865f1e6f84a12246d26bf
Author: Lisa Seeto <email address hidden>
Date: Tue Apr 30 15:11:12 2019 +1200

Bug 1826974: Deleting a non-instiutional tag from file produces a warning

remove_prefix from newtag only if it's not empty

behatnotneeded

Change-Id: I7605e1bdf05b8f2238d2fba2e95b1f9919e899a0
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9925

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9925
Committed: https://git.mahara.org/mahara/mahara/commit/6b56f52dce9fbe5c6b585dc7801c005e5ebd6d57
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 6b56f52dce9fbe5c6b585dc7801c005e5ebd6d57
Author: Lisa Seeto <email address hidden>
Date: Tue Apr 30 15:11:12 2019 +1200

Bug 1826974: Deleting a non-instiutional tag from file produces a warning

remove_prefix from newtag only if it's not empty

behatnotneeded

Change-Id: I7605e1bdf05b8f2238d2fba2e95b1f9919e899a0
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 9cfe3bb987c4bc270ec865f1e6f84a12246d26bf)