Reading unread emails not marking them as read

Bug #1826956 reported by Robert Lyon on 2019-04-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon

Bug Description

This is caused by changes with bootstrap going from panels to cards

Robert Lyon (robertl-9) wrote :

To test:

Have a user with notifications set to 'inbox'

Send them some emails (as another user)

Try reading email in inbox block on homepage
Try reading email in inbox box

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
importance: Medium → High
milestone: none → 19.04.0
assignee: nobody → Robert Lyon (robertl-9)
Steven (stevens-q) wrote :

Commit hash: 6b74e621d3f43fa54a01f7f7413bce226e7bab4e
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles User3)
  a) notifications set to 'inbox'
2) User has unread notifications in their inbox

TEST STEPS:
------------------------
1) Log in as Mahara User1
2) Verify that user has unread notifications (Subject text is bold & Inbox unread notification counter will indicate how many)
3) Click on the notification
4) Verify that the Subject text is now displayed as regular text
5) Verify that the unread notification counter indicates one less for the count)

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9915
Committed: https://git.mahara.org/mahara/mahara/commit/d6ffd9b19c199f250768c6e2058c987ed5b300cd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d6ffd9b19c199f250768c6e2058c987ed5b300cd
Author: Robert Lyon <email address hidden>
Date: Tue Apr 30 12:41:24 2019 +1200

Bug 1826956: Problem with unread mails

This patch fixes the js problem:
- Marking read emails in inbox was not updating the status
- Marking read emails in inbox block was not updating the status

Also fixes php problem:
- Marking read user messages in the inbox block

behatnotneeded

Change-Id: Icba09033812a6dbdaf017561a11cb40cad5dc782
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9928
Committed: https://git.mahara.org/mahara/mahara/commit/61c4d4090dd63902926135f8ab56486f3761ddf4
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 61c4d4090dd63902926135f8ab56486f3761ddf4
Author: Robert Lyon <email address hidden>
Date: Tue Apr 30 12:41:24 2019 +1200

Bug 1826956: Problem with unread mails

This patch fixes the js problem:
- Marking read emails in inbox was not updating the status
- Marking read emails in inbox block was not updating the status

Also fixes php problem:
- Marking read user messages in the inbox block

behatnotneeded

Change-Id: Icba09033812a6dbdaf017561a11cb40cad5dc782
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d6ffd9b19c199f250768c6e2058c987ed5b300cd)

Robert Lyon (robertl-9) on 2019-04-30
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers