Border around blocks on institution and site pages

Bug #1826814 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned

Bug Description

Follow-on report from the Bootstrap 4 upgrade.

When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue.

The problem does not occur in personal and group pages that have blocks.

To replicate:

1. Log in as site admin and create an institution.
2. Create a page in Admin menu -> Configure site -> Pages and collections.
3. Add a block to the page.
Expected result: There is no extra border around the blocks.
Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode.

4. Create a page in Admin menu -> Institutions -> Pages and collections.
5. Add a block to the page.
Expected result: There is no extra border around the blocks.
Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode.

Tags: regression
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9905

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9905
Committed: https://git.mahara.org/mahara/mahara/commit/6a615b82f8ef883827fc3f97a28e024ff2eddfbc
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 6a615b82f8ef883827fc3f97a28e024ff2eddfbc
Author: Robert Lyon <email address hidden>
Date: Tue Apr 30 07:52:30 2019 +1200

Bug 1826814: Removing border from blocks on site/institution pages

behatnotneeded

Change-Id: I2e31e7e83a0cb1825b1e0d3e9f79badcc36fb7fd
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9910

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9910
Committed: https://git.mahara.org/mahara/mahara/commit/274f6bbd472b0730a44b9755bcac48e208d6d2b0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 274f6bbd472b0730a44b9755bcac48e208d6d2b0
Author: Robert Lyon <email address hidden>
Date: Tue Apr 30 07:52:30 2019 +1200

Bug 1826814: Removing border from blocks on site/institution pages

behatnotneeded

Change-Id: I2e31e7e83a0cb1825b1e0d3e9f79badcc36fb7fd
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6a615b82f8ef883827fc3f97a28e024ff2eddfbc)

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.