Wrong link text color in "More options" page menu when link is active

Bug #1826801 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Liam
19.04
Fix Released
Medium
Unassigned
19.10
Fix Released
Medium
Liam

Bug Description

Follow-on from Bootstrap 4 upgrade

When you are on a page and click the "More options" menu and then hover to an option and press the mouse to activate the link, the text color stays black but the background changes to the theme's primary color making the text often unreadable.

The text color should change according to the primary button color combo.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Liam (liam-sharpe)
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9939

Changed in mahara:
milestone: none → 19.10.0
Revision history for this message
Steven (stevens-q) wrote :

Commit hash: ac09a0e459adc0a407cf2e302ed6559f6336d85b
Environment tested: Master
Browser tested: Chrome
Theme used: Default raw | Raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Portfolio page exists

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to the Portfolio page in display view
3) Click the "More options" menu and then hover to an option and press the mouse to activate the link
4) Verify the text color changes to white, according to the primary button color combo. for each themes (ie White text on green background for Raw theme) ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9939
Committed: https://git.mahara.org/mahara/mahara/commit/ac09a0e459adc0a407cf2e302ed6559f6336d85b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ac09a0e459adc0a407cf2e302ed6559f6336d85b
Author: Liam <email address hidden>
Date: Wed May 1 10:18:05 2019 +1200

Bug #1826801: Wrong link text color in "More options" page menu when link is active

behatnotneeded

Change-Id: Id912eb6b7d2b25216b29861a35c40d0eed77ebd9

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10124

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10124
Committed: https://git.mahara.org/mahara/mahara/commit/7535bc69a07e5ed8f91cc0c28be64a393fa01e2f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 7535bc69a07e5ed8f91cc0c28be64a393fa01e2f
Author: Liam <email address hidden>
Date: Wed May 1 10:18:05 2019 +1200

Bug #1826801: Wrong link text color in "More options" page menu when link is active

behatnotneeded

Change-Id: Id912eb6b7d2b25216b29861a35c40d0eed77ebd9
(cherry picked from commit ac09a0e459adc0a407cf2e302ed6559f6336d85b)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.