The "Uploaded by" option should only be visible when the owner is different from the uploader

[Kristina Hoeppner]

In bug #1815807 we added the person's name to the file properties to see who uploaded a file. This information should not be visible in the personal files area as it is superfluous. It can stay available in the group, institution, and site files areas as there are multiple people who could potentially upload files and thus differentiating who did would be a good thing for transparency.

To replicate:

1. Log in as site admin.
2. Upload a file to your personal files area and click the "Edit" button.
Expected result: There is no mention of "Uploaded by"
Actual result: "Uploaded by ..." is displayed.

3. Add the file to a page.
4. Click the file to view its details page.
Expected result: There is no mention of "Uploaded by"
Actual result: "Uploaded by ..." is displayed.

5. Upload a file to a group.
6. Click the "Edit" button to view the file properties.
Expected and actual result: "Uploaded by ..." is displayed.

7. Add the group file to a group page.
8. Click the file to view its details page.
Expected and actual result: "Uploaded by ..." is displayed.

Repeat 5-8 for institution and site files with the same results.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9886

[Kristina Hoeppner (kris-hoeppner)]

When a template is copied that contains a file, the "Uploaded by" is displayed on the resulting page as a different person than the portfolio author would have uploaded the file. This allows for transparency without displaying information twice.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9886
Committed: https://git.mahara.org/mahara/mahara/commit/4f2187880d2f19ddbec071c3bf235fccbcb52ea6
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 4f2187880d2f19ddbec071c3bf235fccbcb52ea6
Author: Robert Lyon <email address hidden>
Date: Mon Apr 29 10:03:10 2019 +1200

Bug 1826766: Only show 'uploaded by' if the viewer is not owner

behatnotneeded

Change-Id: I299b411bd3d5368ce11997bc6390a04ddc121279
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9911

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9911
Committed: https://git.mahara.org/mahara/mahara/commit/056be41a34fa06404609054bc650eecc28d0f37a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 056be41a34fa06404609054bc650eecc28d0f37a
Author: Robert Lyon <email address hidden>
Date: Mon Apr 29 10:03:10 2019 +1200

Bug 1826766: Only show 'uploaded by' if the viewer is not owner

behatnotneeded

Change-Id: I299b411bd3d5368ce11997bc6390a04ddc121279
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4f2187880d2f19ddbec071c3bf235fccbcb52ea6)

[Kristina Hoeppner (kris-hoeppner)]

We decided to show the "Uploaded by" also in other areas where many people could upload files, e.g. site and institution level.

The added bonus: When a person copies a page with a file into their personal portfolio area, the "Uploaded by" stays the original upload person.