Mahara

Tags on file list displaying with tag count when they shouldn't

Bug #1825611 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 19.04.0

Bug Description

The patch https://reviews.mahara.org/#/c/9577/ caused an issue where the tags now display with the tag count when it doesn't need to.

We should make the display_tag() function have an option where we can show / not show the tag count

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9809

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 19.04.0
importance: Undecided → High
tags: added: regression
Changed in mahara:
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9809
Committed: https://git.mahara.org/mahara/mahara/commit/5830f08eedc0345f4b4fa412085ad214cd53aa0c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5830f08eedc0345f4b4fa412085ad214cd53aa0c
Author: Robert Lyon <email address hidden>
Date: Sat Apr 20 18:27:45 2019 +1200

Bug 1825611: Don't show tag count beside tag on file list page

Allow choice for showing the tag count

behatnotneeded

Change-Id: Ic54ba03c5f52da4ca0c4c791b0bb1a217193ad4c
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9853

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9853
Committed: https://git.mahara.org/mahara/mahara/commit/b9398402f3e4db3bc9c91d00c658039766d58fc1
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit b9398402f3e4db3bc9c91d00c658039766d58fc1
Author: Robert Lyon <email address hidden>
Date: Sat Apr 20 18:27:45 2019 +1200

Bug 1825611: Don't show tag count beside tag on file list page

Allow choice for showing the tag count

behatnotneeded

Change-Id: Ic54ba03c5f52da4ca0c4c791b0bb1a217193ad4c
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5830f08eedc0345f4b4fa412085ad214cd53aa0c)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.