Site pages and collections : Page template become unavailable after changing settings

Bug #1824767 reported by Luc Stavaux
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned

Bug Description

Hello,

I use Mahara.18.10.0 on ubuntu 18.10, php7.3, apache2 and Postgres 10.7.

When I edit the settings of the page template in the site pages and collections's menu, the page template become unavailable.

More precisely, this bug (i think it's a bug but i'm not sure) append when I want to disable the comments in the Share's settings. When I save this modification, the page template is no more a template. I made a little video to show the bug.

To correct this problem, I must restore an old version of the database (postgresql).

Is it a bug ?
Is it a way to disable the comment block in the page template ?

Thanks,

Luc

Revision history for this message
Luc Stavaux (luc.stavaux) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

A site template (Dashboard template, Group homepage template, Profile template and Page template) should not have the edit access section enabled.

To fix this we have to:
1. Remove the "Share" button at the top right of the edit block for those 4 site templates.
2. Throw exception if we want to access 'view/accessurl.php' of 'view/access.php' with one of the site templates view ids

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9943

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hi Luc,

Please feel free to check out the fix for the problem at https://reviews.mahara.org/9943 and let us know in the code review system if this resolves the problem. You can use your Launchpad account to log in to https://reviews.mahara.org

Thank you
Kristina

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 0e1d50d422e43e93addc46411fee5374617b03dd
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Site admin exists

TEST STEPS:
------------------------
1) Log in as SIte admin
2) Browse to admin menu > Configure site > Pages and collections
3) Verify that the share button is not displayed for the following Template pages ✔
      a) Dashboard template ✔
      b) Group home page template ✔
      c) Profile template ✔
      d) Page template ✔

Catalyst QA Approved ✔

Revision history for this message
Luc Stavaux (luc.stavaux) wrote :

Hello,

I applied the patch.

Now, when i connect as site admin, the share button is no more accessible when i try to edit a site template.

The bug is fixed ;-) !

Thank you,

Luc.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9943
Committed: https://git.mahara.org/mahara/mahara/commit/0e1d50d422e43e93addc46411fee5374617b03dd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0e1d50d422e43e93addc46411fee5374617b03dd
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 2 15:02:05 2019 +1200

Bug 1824767: site template should not have the edit access section

behatnotneeded

Change-Id: I40553bc4ebf69eef950f1c170d442aa7a963efe0

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10170

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10170
Committed: https://git.mahara.org/mahara/mahara/commit/c8c897cc3614f7f94323778dcf93d9ef3c09566f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit c8c897cc3614f7f94323778dcf93d9ef3c09566f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 2 15:02:05 2019 +1200

Bug 1824767: site template should not have the edit access section

behatnotneeded

Change-Id: I40553bc4ebf69eef950f1c170d442aa7a963efe0
(cherry picked from commit 0e1d50d422e43e93addc46411fee5374617b03dd)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10171

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10171
Committed: https://git.mahara.org/mahara/mahara/commit/59ab073df2b01cfbbd333287dd0da11e08055fe8
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 59ab073df2b01cfbbd333287dd0da11e08055fe8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 2 15:02:05 2019 +1200

Bug 1824767: site template should not have the edit access section

behatnotneeded

Change-Id: I40553bc4ebf69eef950f1c170d442aa7a963efe0
(cherry picked from commit 0e1d50d422e43e93addc46411fee5374617b03dd)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10172

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10172
Committed: https://git.mahara.org/mahara/mahara/commit/6e932908f9f5923aec79dc71f979accbaa56f5ad
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 6e932908f9f5923aec79dc71f979accbaa56f5ad
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 2 15:02:05 2019 +1200

Bug 1824767: site template should not have the edit access section

behatnotneeded

Change-Id: I40553bc4ebf69eef950f1c170d442aa7a963efe0
(cherry picked from commit 0e1d50d422e43e93addc46411fee5374617b03dd)

Revision history for this message
Rangi Daymond (rangid) wrote :

Note: refer Behat bug 1862839 - these tests also include checking that each edit template page does not include a "Share" button too.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10756

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10756
Committed: https://git.mahara.org/mahara/mahara/commit/7d5897aa59d6f8ec24dd24d9fdf8f830e157ad4d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 7d5897aa59d6f8ec24dd24d9fdf8f830e157ad4d
Author: Rangi Daymond <email address hidden>
Date: Wed Feb 12 13:26:00 2020 +1300

Bug 1862839 Behat: update feature inc Bug 1824767
Refer to Bug 1824767 Site pages and collections : Page template become
unavailable after changing settings

Update Behat test site_page_with_template_blocks.feature to include
checks that there is no access:
a) to "Share" on any of the four template cards, and,
b) to "Share" within any of the four edit template pages.

Change-Id: I917e69b044562b2f9fb4f296bb2d2a7613f67c37

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers