Site pages and collections : Page template become unavailable after changing settings

Bug #1824767 reported by Luc Stavaux on 2019-04-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.10
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned

Bug Description

Hello,

I use Mahara.18.10.0 on ubuntu 18.10, php7.3, apache2 and Postgres 10.7.

When I edit the settings of the page template in the site pages and collections's menu, the page template become unavailable.

More precisely, this bug (i think it's a bug but i'm not sure) append when I want to disable the comments in the Share's settings. When I save this modification, the page template is no more a template. I made a little video to show the bug.

To correct this problem, I must restore an old version of the database (postgresql).

Is it a bug ?
Is it a way to disable the comment block in the page template ?

Thanks,

Luc

Luc Stavaux (luc.stavaux) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → High

A site template (Dashboard template, Group homepage template, Profile template and Page template) should not have the edit access section enabled.

To fix this we have to:
1. Remove the "Share" button at the top right of the edit block for those 4 site templates.
2. Throw exception if we want to access 'view/accessurl.php' of 'view/access.php' with one of the site templates view ids

Hi Luc,

Please feel free to check out the fix for the problem at https://reviews.mahara.org/9943 and let us know in the code review system if this resolves the problem. You can use your Launchpad account to log in to https://reviews.mahara.org

Thank you
Kristina

Steven (stevens-q) wrote :

Commit hash: 0e1d50d422e43e93addc46411fee5374617b03dd
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Site admin exists

TEST STEPS:
------------------------
1) Log in as SIte admin
2) Browse to admin menu > Configure site > Pages and collections
3) Verify that the share button is not displayed for the following Template pages ✔
      a) Dashboard template ✔
      b) Group home page template ✔
      c) Profile template ✔
      d) Page template ✔

Catalyst QA Approved ✔

Luc Stavaux (luc.stavaux) wrote :

Hello,

I applied the patch.

Now, when i connect as site admin, the share button is no more accessible when i try to edit a site template.

The bug is fixed ;-) !

Thank you,

Luc.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers