Panels on report "Information overview" shouldn't be colorized

Bug #1824673 reported by Kristina Hoeppner on 2019-04-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Doris Tam

Bug Description

Regression after upgrade to Bootstrap 4

When you go to Admin menu -> Reports (/admin/users/statistics.php), the "Information overview" report is the default. The individual columns are shown in blue panels (in the Default theme), when there shouldn't be any panel highlights (see attached screenshot with what it looks like in 18.10).

To replicate:

1. Log in as site admin.
2. Got to Admin menu -> Reports.

Expected result: The page looks like in Mahara 18.10.
Actual result: Each column has an outline and a heading background.

This will need to be checked in all themes.

Doris Tam (doristam) on 2019-04-14
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
status: Confirmed → In Progress
Steven (stevens-q) wrote :

Commit hash: a8c2f4ed15f3e8341363f951c5b9cec230354b7b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Mahara users exist (need to have some not many users)
2) Users should have some portfolio pages
NOTE: you need to have some data in your site to generate a decent report

TEST STEPS:
------------------------
1) Log in as site admin.
2) Go to Admin menu -> Reports.
3) Verify that ther are no coloured headings for the blocks ✔
4) Verify that ther are no coloured headings for the blocks for the following themes Using the above steps
    a) Raw ✘
    b) Default raw ✔
    c) Ocean ✘
    d) Modern ✘
    e) Primary school ✘

Catalyst QA Approved ✔

Steven (stevens-q) wrote :

Raw theme has light grey background where there should be none

Steven (stevens-q) wrote :
Steven (stevens-q) wrote :

Reviewed: https://reviews.mahara.org/9764
Committed: https://git.mahara.org/mahara/mahara/commit/0744102e3b3056e50ac53ccb589c2707b62e43e9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0744102e3b3056e50ac53ccb589c2707b62e43e9
Author: Doris Tam <email address hidden>
Date: Mon Apr 15 10:22:34 2019 +1200

Bug 1824673: Changes to make panels on report "Information Overview" look like it did in 18.10

Decolorize the blue headings and remove the table boxes.

behatnotneeded

Change-Id: I5fb3892f114fd62db673cb68ab494929b38de129

Reviewed: https://reviews.mahara.org/9799
Committed: https://git.mahara.org/mahara/mahara/commit/6f1db049596e42524a965c4dee0a29256607b15f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 6f1db049596e42524a965c4dee0a29256607b15f
Author: Doris Tam <email address hidden>
Date: Mon Apr 15 10:22:34 2019 +1200

Bug 1824673: Changes to make panels on report "Information Overview" look like it did in 18.10

Decolorize the blue headings and remove the table boxes.

behatnotneeded

Change-Id: I5fb3892f114fd62db673cb68ab494929b38de129
(cherry picked from commit 0744102e3b3056e50ac53ccb589c2707b62e43e9)

Robert Lyon (robertl-9) on 2019-04-17
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers