Show the sign-off block content in the block rather than just below the page header

Bug #1824439 reported by Robert Lyon on 2019-04-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon

Bug Description

Now that we are doing a different layout for the page header we need to move the sign-off content back into the block itself

Robert Lyon (robertl-9) on 2019-04-11
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 19.04.0
Steven (stevens-q) wrote :

Commit hash: 320508426ebddb8e02e75aa5537c6364bae01593
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Portfolio page exists with 3 column layout and has the following blocks
     a) text block (top left)
     b) image block (centre column)
     c) sign off block (top right column

TEST STEPS:
------------------------
1) Log in as Mahar user
2) Browse to the portfolio page mentioned above in page display view
3) Verify that the signoff block is displayed as it's own block on the page ✔
4) Verify that the block does not display in the page header (grey area top of page) ✔

Catalyst QA Approved ✔

Steven (stevens-q) wrote :

Reviewed: https://reviews.mahara.org/9754
Committed: https://git.mahara.org/mahara/mahara/commit/320508426ebddb8e02e75aa5537c6364bae01593
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 320508426ebddb8e02e75aa5537c6364bae01593
Author: Robert Lyon <email address hidden>
Date: Fri Apr 12 10:52:08 2019 +1200

Bug 1824439: Positioning the signoff block contents back into sign-off block

behatnotneeded

Change-Id: I2746b380b024dfa8a3ad58e600dd031f95930749
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/9788
Committed: https://git.mahara.org/mahara/mahara/commit/cdb7e4455b9cd8314bc9e6f5fbdc613a5d038714
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit cdb7e4455b9cd8314bc9e6f5fbdc613a5d038714
Author: Robert Lyon <email address hidden>
Date: Fri Apr 12 10:52:08 2019 +1200

Bug 1824439: Positioning the signoff block contents back into sign-off block

behatnotneeded

Change-Id: I2746b380b024dfa8a3ad58e600dd031f95930749
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 320508426ebddb8e02e75aa5537c6364bae01593)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers