'skip to main content' link skips the new page header on collections

Bug #1824044 reported by Liam on 2019-04-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Lisa Seeto

Bug Description

When tabbing through a page with a screenreader, there is a 'skip to main content' link in the header that allows users to skip having to tab through all of the menu items before getting to the content of a page.

Since the new collection page header has been added, using this link completely misses the header elements.

To replicate:
1. Navigate to create -> Pages and collections
2. Create a page
3. Create a collection
3.1. Add the page from step 2 to the collection
4. View the collection
5. Use the tab key to navigate through the page
6. When 'skip to main content' link appears, click enter

Expected result: Start tabbing through the header section
Actual result: Start tabbing through the comments block (Or another block if one was added in step 2)

Lisa Seeto (lisaseeto) on 2019-04-11
Changed in mahara:
status: New → Confirmed
status: Confirmed → In Progress
Lisa Seeto (lisaseeto) on 2019-04-11
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)

Reviewed: https://reviews.mahara.org/9753
Committed: https://git.mahara.org/mahara/mahara/commit/5d0989ada692ce1185418aab6668c01ad092668e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5d0989ada692ce1185418aab6668c01ad092668e
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 12 10:50:44 2019 +1200

Bug #1824044 'skip to main content' link skips the new page header on collections

Put the pageactions.tpl inside pageheader.tpl so the ordering of
elements is better for screenreaders.

Skip to main content now goes either to #main or #header-content if dealing
with a custom page header. The collection navigation custom-dropdown is now
focusable, with clicking func and tab to and press enter for accessibility.
Style guide updated accordingly.

behatnotneeded

Change-Id: I54c17a69c3f55aa4f896ea02be01e04220d4dd4c

Reviewed: https://reviews.mahara.org/9825
Committed: https://git.mahara.org/mahara/mahara/commit/d78265327e40b1bce97761f661d26fb8792cb728
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d78265327e40b1bce97761f661d26fb8792cb728
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 12 10:50:44 2019 +1200

Bug #1824044 'skip to main content' link skips the new page header on collections

Put the pageactions.tpl inside pageheader.tpl so the ordering of
elements is better for screenreaders.

Skip to main content now goes either to #main or #header-content if dealing
with a custom page header. The collection navigation custom-dropdown is now
focusable, with clicking func and tab to and press enter for accessibility.
Style guide updated accordingly.

behatnotneeded

Change-Id: I54c17a69c3f55aa4f896ea02be01e04220d4dd4c
(cherry picked from commit 5d0989ada692ce1185418aab6668c01ad092668e)

Robert Lyon (robertl-9) on 2019-04-23
Changed in mahara:
milestone: none → 19.04.0
importance: Undecided → High
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers