Incorrect error message on SmartEvidence upload page

Bug #1823864 reported by Kristina Hoeppner on 2019-04-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic

Bug Description

Issue only in Mahara 19.04RC1 / master due to addition of SmartEvidence editor.

When you attempt to upload a SmartEvidence file that does not have well-formatted JSON, the error message alludes to more info further down the page when there is no further information. That error message is taken from the "Editor" page but needs to be adapted for the "Upload" page.

To replicate:

1. Go to Admin menu -> Extensions -> SmartEvidence -> Upload.
2. Upload a SmartEvidence .matrix file that has errors, e.g. create a file with a single word and save it as .matrix.

Expected result: The error message says: "This is not a valid .matrix file: Unable to parse the JSON content."

Actual result: The error message says: "The current form has invalid json. Please scroll down the page to see the specific error."

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/9740
Committed: https://git.mahara.org/mahara/mahara/commit/f8b2a68a66e4575a6ebd4ee2222b284a013923d9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f8b2a68a66e4575a6ebd4ee2222b284a013923d9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 10 16:44:34 2019 +1200

Bug 1823864: JSON editor- uploading matrix error string

behatnotneeded

Change-Id: I33163939fb71a5484b1d71f6ff00ba2d1506b0bb

Reviewed: https://reviews.mahara.org/9761
Committed: https://git.mahara.org/mahara/mahara/commit/1ae4cfca6565e878e70af0863213cc02a6cbd11f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 1ae4cfca6565e878e70af0863213cc02a6cbd11f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 10 16:44:34 2019 +1200

Bug 1823864: JSON editor- uploading matrix error string

behatnotneeded

Change-Id: I33163939fb71a5484b1d71f6ff00ba2d1506b0bb
(cherry picked from commit f8b2a68a66e4575a6ebd4ee2222b284a013923d9)

Robert Lyon (robertl-9) on 2019-04-13
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers