Can't set remoteusername anymore

[Kristina Hoeppner]

Tested in Mahara 18.10 and master

It is not possible anymore to change the remote username from the site user account settings screen /admin/users/edit.php?id= (Admin menu -> Users -> User search -> Click on a username). When a remote auth method (MNet, SAML, web services) is selected, the field "Username for external authentication" should become visible so that the remote username can be entered or changed there.

I don't see that field anymore (see attached screenshot).

To replicate:

1. Set up an institution with MNet or SAML.
2. Set the auth method for a user account to MNet / SAML.
Expected result: The "Username for external authentication" field should show up.
Actual result: Nothing happens, not even after saving the page.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9738

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9738
Committed: https://git.mahara.org/mahara/mahara/commit/03b8a0a63a8a85c6edde59cd0cf01382f70ddd87
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 03b8a0a63a8a85c6edde59cd0cf01382f70ddd87
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 10 16:19:27 2019 +1200

Bug 1823783: remote username in user edit screen - adding back missing code

need to populate js variable that contains external auth instances

this code was removed in following patch but we need it
https://reviews.mahara.org/#/c/8528/21

behatnotneeded

Change-Id: I7789cd3f61738de775df73c6eb5f1bc7a7f039be

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9741

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9741
Committed: https://git.mahara.org/mahara/mahara/commit/f8ee1cd0496d597e74c768c5822c4dd2af168118
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit f8ee1cd0496d597e74c768c5822c4dd2af168118
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 10 16:19:27 2019 +1200

Bug 1823783: remote username in user edit screen - adding back missing code

need to populate js variable that contains external auth instances

this code was removed in following patch but we need it
https://reviews.mahara.org/#/c/8528/21

behatnotneeded

Change-Id: I7789cd3f61738de775df73c6eb5f1bc7a7f039be
(cherry picked from commit 03b8a0a63a8a85c6edde59cd0cf01382f70ddd87)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9742

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9742
Committed: https://git.mahara.org/mahara/mahara/commit/5203ac74cdf74ec475125e9701db55f6d6434d6a
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 5203ac74cdf74ec475125e9701db55f6d6434d6a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 10 16:19:27 2019 +1200

Bug 1823783: remote username in user edit screen - adding back missing code

need to populate js variable that contains external auth instances

this code was removed in following patch but we need it
https://reviews.mahara.org/#/c/8528/21

behatnotneeded

Change-Id: I7789cd3f61738de775df73c6eb5f1bc7a7f039be
(cherry picked from commit 03b8a0a63a8a85c6edde59cd0cf01382f70ddd87)
(cherry picked from commit f8ee1cd0496d597e74c768c5822c4dd2af168118)