Padding between profile image and name on friend request / denial / removal page

Bug #1823506 reported by Kristina Hoeppner on 2019-04-07
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Evonne Cheung

Bug Description

This is an issue that has come up after the upgrade to Bootstrap 4.

There is no space between the profile image and the name of the person on the "Send NAME a friendship request" page /user/requestfriendship.php?id= (see attachment).

To replicate:

1. Set up 2 people.
2. User A requests friendship of User B on /user/index.php by clicking the "Send friend request" link.
3. On the "Send User B a friendship request" page...

Expected result: There should be some padding between the profile picture and the name as per https://manual.mahara.org/en/18.10/_images/friend_request.png
Actual result: There is no padding.

The same applies when you are on the "Deny friend request" page /user/denyrequest.php after having clicked the "Deny" button. And also on the "Remove friend" page /user/removefriend.php

tags: added: bite-
tags: added: bite-sized
removed: bite-
Changed in mahara:
assignee: nobody → Evonne Cheung (evonne)
tags: added: usermanualupdate
description: updated
summary: - Padding between profile image and name on friend request page
+ Padding between profile image and name on friend request / denial /
+ removal page
description: updated
Evonne Cheung (evonne) on 2019-04-09
Changed in mahara:
status: Confirmed → In Progress
Evonne Cheung (evonne) wrote :

Added 10px space between user icon and user name in raw. Tested on all 3 pages.

https://reviews.mahara.org/#/c/9725/

Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/9725
Committed: https://git.mahara.org/mahara/mahara/commit/ed06b49104f85ba754cdb05cb2d2e4c68ac81627
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ed06b49104f85ba754cdb05cb2d2e4c68ac81627
Author: Evonne Cheung <email address hidden>
Date: Tue Apr 9 12:03:56 2019 +1200

Bug #1823506 Padding between profile image and name on friend request

Space added between user icon and user name on friend request / denial
/ removal page.

behatnotneeded

Change-Id: I4f0db56cf50f4f092b9c2f1b917457519fe03720

Reviewed: https://reviews.mahara.org/9731
Committed: https://git.mahara.org/mahara/mahara/commit/62cb41b0176fa9b3beefcad63814d8e2faecdee6
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 62cb41b0176fa9b3beefcad63814d8e2faecdee6
Author: Evonne Cheung <email address hidden>
Date: Tue Apr 9 12:03:56 2019 +1200

Bug #1823506 Padding between profile image and name on friend request

Space added between user icon and user name on friend request / denial
/ removal page.

behatnotneeded

Change-Id: I4f0db56cf50f4f092b9c2f1b917457519fe03720
(cherry picked from commit ed06b49104f85ba754cdb05cb2d2e4c68ac81627)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers