The jsoneditor and behat html-formatter look to have bootstrap3 files associated

Bug #1823277 reported by Robert Lyon on 2019-04-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Liam

Bug Description

I see there are these files

htdocs/js/jsoneditor/src/themes/bootstrap3.js
htdocs/js/jsoneditor/src/themes/bootstrap4.js

And

htdocs/testing/frameworks/behat/html-formatter/bootstrap.min.css
that contains: Bootstrap v3.3.1

So we need to look into this some more to see if we are actually using the v3 files and if so can we get things working with bootstrap v4?

If not can we remove them from the system?

Robert Lyon (robertl-9) on 2019-04-05
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
milestone: none → 19.04rc1
Liam (liam-sharpe) on 2019-04-16
Changed in mahara:
status: New → In Progress

Reviewed: https://reviews.mahara.org/9789
Committed: https://git.mahara.org/mahara/mahara/commit/ee52401d739536279d7f0a9784709c1a088ba672
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ee52401d739536279d7f0a9784709c1a088ba672
Author: Liam <email address hidden>
Date: Wed Apr 17 11:31:30 2019 +1200

Bug #1823277: Removed bootstrap 3 files from html report and json editor

behatnotneeded

Change-Id: I915b77cbcf535508b16f5f6c5d684b9b1d29c111

Reviewed: https://reviews.mahara.org/9792
Committed: https://git.mahara.org/mahara/mahara/commit/77198f61d05a62876a8e78337c3a98dfa6e2bba9
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 77198f61d05a62876a8e78337c3a98dfa6e2bba9
Author: Liam <email address hidden>
Date: Wed Apr 17 11:31:30 2019 +1200

Bug #1823277: Removed bootstrap 3 files from html report and json editor

behatnotneeded

Change-Id: I915b77cbcf535508b16f5f6c5d684b9b1d29c111
(cherry picked from commit ee52401d739536279d7f0a9784709c1a088ba672)

Robert Lyon (robertl-9) on 2019-04-17
Changed in mahara:
milestone: 19.04rc1 → 19.04.0
importance: Undecided → Low
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers