Two $string['portfolio'] language strings in view.php lang file

Bug #1820927 reported by Robert Lyon on 2019-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
17.10
Medium
Unassigned
18.04
Medium
Unassigned
18.10
Medium
Unassigned
19.04
Medium
Robert Lyon

Bug Description

There is

$string['portfolio'] = 'portfolio';

and

$string['portfolio'] = 'Portfolio';

but only the second one gets used

We need to sort this out so uppercase one is

$string['Portfolio'] = 'Portfolio';

To test:
Before patch

1) Create a group as an admin and turn on 'participation report'
2) Go to the group 'report' page and see it mention '1 Portfolio' (should say '1 portfolio')
3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

Robert Lyon (robertl-9) on 2019-03-19
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 19.04.0
importance: Undecided → Medium
status: New → In Progress
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Scenario 1 -Site admin creates group and enables 'participation report'

PRECONDITIONS:
------------------------
1) Site admin exists
2) Site admin creates a "Site Participate Group" and 'participation report' is enabled
3) Reports page (admin -> reports) = Report configuration = All institutions and Report type is set to Overview

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to "Site Participate Group" report page
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) Site admin Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔ (note Upper case P)

====================================

Scenario 2 -Inst admin creates group and enables 'participation report'

PRECONDITIONS:
------------------------
1) User1 exists and is an Institution One admin
2) Institution One exists
3) Institution One admin creates "Participate Group" and 'participation report' is enabled
4) "Participate Group" exists and has the following members
  a) User1 - admin - has not added group page
  b) User3 - member - has added group page also has created a portfolio page
  c) User4 - member - has not added group page
5) Reports page (admin -> reports) = Report configuration = Institution One and Report type is set to Overview

TEST STEPS:
------------------------
1) Log in as User1
2) Browse to "Participate Group" report page
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) User1 Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9640
Committed: https://git.mahara.org/mahara/mahara/commit/11534107429252db169e7445dd31f53e4d9c27a7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 11534107429252db169e7445dd31f53e4d9c27a7
Author: Robert Lyon <email address hidden>
Date: Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9679

Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9681

Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Scenario 1 -Site admin creates group and enables 'participation report'

PRECONDITIONS:
------------------------
1) Site admin exists
2) Site admin creates a "Site Participate Group" and 'participation report' is enabled
3) Reports page (admin -> reports) = Report configuration = All institutions and Report type is set to Overview

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to "Site Participate Group" report page
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) Site admin Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔ (note Upper case P)

====================================

Scenario 2 -Inst admin creates group and enables 'participation report'

PRECONDITIONS:
------------------------
1) User1 exists and is an Institution One admin
2) Institution One exists
3) Institution One admin creates "Participate Group" and 'participation report' is enabled
4) "Participate Group" exists and has the following members
  a) User1 - admin - has not added group page
  b) User3 - member - has added group page also has created a portfolio page
  c) User4 - member - has not added group page
5) Reports page (admin -> reports) = Report configuration = Institution One and Report type is set to Overview

TEST STEPS:
------------------------
1) Log in as User1
2) Browse to "Participate Group" report page
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)

NOTE: The following must be run before the graph displays
      a) Force the cron to run the daily stats by running this command in database: UPDATE cron SET nextrun = NULL;
      b) In a terminal run: sudo -u www-data php htdocs/lib/cron.php

4) User1 Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔

Further Testing
---------------------------------------------
Run the above test scripts on the following versions
a) 18.10_STABLE ✔
b) 18.04_STABLE ✔
c) 17.10_STABLE ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9681
Committed: https://git.mahara.org/mahara/mahara/commit/a99b9b21dd2407283228ba11e0eee8b9fbed1d54
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit a99b9b21dd2407283228ba11e0eee8b9fbed1d54
Author: Robert Lyon <email address hidden>
Date: Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9680
Committed: https://git.mahara.org/mahara/mahara/commit/750dac4b7693ad933658236ff4f0a8e1ce4c6ff9
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 750dac4b7693ad933658236ff4f0a8e1ce4c6ff9
Author: Robert Lyon <email address hidden>
Date: Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9679
Committed: https://git.mahara.org/mahara/mahara/commit/b4322aa81a7f7512679e318acaf3b1ec041e62e3
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit b4322aa81a7f7512679e318acaf3b1ec041e62e3
Author: Robert Lyon <email address hidden>
Date: Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers