Add small logo to a theme

Bug #1817809 reported by Kristina Hoeppner on 2019-02-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Lisa Seeto

Bug Description

It is possible to upload a small logo via Admin menu -> Institutions -> Settings to each institution. However, the default themes in Mahara don't seem to provide the opportunity to have a small logo there per default, which makes it harder to theme because then no small logo could be uploaded via the theme.

What should be possible?

1. Add a small sitelogo (as SVG and PNG file) into the raw theme and other themes that contain a custom theme. That way, the logo would be picked up when the default themes are viewed. Logo files are provided below.

We have several versions of the logo to account for dark backgrounds and light backgrounds in the configurable theme. Some of the other themes might also have their own version of the logo on the site to accommodate the background.

2. When an institution uploaded a custom regular logo but no custom small logo, do not switch to the built-in small logo as that would change the brand. Keep the normal uploaded logo that gets a bit smaller.

3. Rename "Small logo" in the institution settings to "Mobile logo" to make it more obvious that people should upload it. We can't force the upload of a logo though. A new language string ID needs to be created so that it's picked up by the translators.

When an institution uploads a small logo that will be used instead. That already does work.

To summarize for what should be possible in the end:
A. No logo or mobile logo uploaded through the admin area: Use the theme's logo and mobile logo.

B.Logo uploaded through the admin area: Use that logo instead of the theme's logo. Use it also on mobile devices and do not switch to the theme's mobile logo.

C. Logo and mobile logo uploaded through the admin area: Use both instead of the theme's logo and mobile logo.

The small logo in all the necessary versions for upload (SVG, PNG, light, dark, normal).

Note: The logo is not centered in the file but left aligned so that it sits on the left with the correct space to the screen edge.

description: updated
Lisa Seeto (lisaseeto) on 2019-03-05
Changed in mahara:
status: Confirmed → In Progress
description: updated
Lisa Seeto (lisaseeto) wrote :

Please confirm the following:

Text changes:
1. The text on the institution settings page for the small logo has changed from "Small logo" to "Mobile logo".

Please note: The screen is considered small at 415px.

Logo:
Have an institution with at least one member who will see theme changes when logged in. Log in as admin of institution, go to the settings page to the "Logo" and "Mobile Logo" and "Theme" drop-down to make necessary changes, use the member of the institution to confirm changes. Default Mahara logo's should change colour from light to dark versions depending on the background colour they are displayed upon. Custom logo's do NOT change as it is assumed that the user has chosen their colours intentionally.

1. No custom logo and no custom mobile logo for all themes in the drop-down option:
Full screen: The default Mahara logo displays
Small screen: The default Mahara mobile logo displays
Both screens: The default logos are colour appropriate, i.e dark on light header backgrounds, light on dark backgrounds

2. A custom logo but no custom mobile logo
Full screen: The custom logo displays
Small screen: The custom logo displays

3. A custom logo and a custom mobile
Full screen: The custom logo displays
Small screen: The custom mobile logo displays

4. No custom logo, a custom mobile logo
Full screen: The default Mahara logo displays
Small screen: The custom mobile logo displays

Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Institution exists
2) Large Institution logo exists (160px X 50px) - (used instead of Mahara logo)
3) Small Institution logo exists (50px X 50px) - (used instead of Mahara logo

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to the Institution settings page (admin menu > Institutions > Settings > click the Gear edit icon
3) Verify the label "Mobile logo" and choose file field are displayed ✔
4) Confirm the following scenarios:

   a) No logo uploaded and no mobile logo uploaded
    - Desktop = Mahara Icon and Mahara logo displayed ✔
   - mobile = Mahara Icon logo only displayed ✔

   b) Logo uploaded and no mobile logo uploaded
    - Desktop = Large Institution logo displayed ✔
    - mobile = Large Institution logo displayed scaled down to fit ✔

   c) No Logo uploaded and Institution mobile logo uploaded
    - Desktop = Mahara Icon and Mahara logo displayed ✔
    - mobile = Institution mobile logo displayed ✔
5) Verify the followin when a mobile icon is uploaded
    a) Delete mobile logo and switch field is displayed ✔

Catalyst QA Approved ✔

Changed in mahara:
milestone: none → 19.04.0
Steven (stevens-q) wrote :

Re-test - no issues found - test script found here https://bugs.launchpad.net/mahara/+bug/1817809/comments/4

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9616
Committed: https://git.mahara.org/mahara/mahara/commit/5a72857a4252624e81933a2509c2fe2bc9513c0f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5a72857a4252624e81933a2509c2fe2bc9513c0f
Author: Lisa Seeto <email address hidden>
Date: Thu Mar 7 14:45:49 2019 +1300

Bug 1817809: Add small logo to a theme

Added default mobile logo to theme.
It will change from light to dark version accordingly.

behatnotneeded

Change-Id: I0bfcdc93a159bad54cf974d3dc3993e22a2ba1eb
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9) on 2019-03-25
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers