Adding comment to journal entry shows wrong poster

Bug #1816311 reported by Robert Lyon on 2019-02-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
17.10
High
Unassigned
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Robert Lyon

Bug Description

When adding a comment to a journal entry artefact via a page we see the piece of information:

 Posted by [owner] on [date]

This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see:

 Posted by [viewer of page] on [date]

Steps to replicate:

1) Login as UserA and create a group, GroupA
2) Create a journal in the group and add a journal entry to it
3) Add a page in GroupA and add the journal block to it and choose the group journal
4) Share the group page with registered users
5) Logout

6) Login as UserB and visit the page
7) Click on the 'Add comment' link for the journal block

The "Posted by..." line will say UserB instead of UserA

Robert Lyon (robertl-9) on 2019-02-17
Changed in mahara:
milestone: none → 19.04.0
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) UserA and UserB exist

TEST STEPS:
------------------------
1) Login as UserA and create a group, GroupA
2) Create a journal in the group and add a journal entry to it
3) Add a page in GroupA and add the journal block to it and choose the group journal
4) Share the group page with registered users
5) Logout
6) Login as UserB and visit the page
7) Click on the 'Add comment' link for the journal block
8) Verify that the "Posted by..." line says UserA ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9573
Committed: https://git.mahara.org/mahara/mahara/commit/5988b7de00b4a12dd71004056aeec3b55e190243
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5988b7de00b4a12dd71004056aeec3b55e190243
Author: Robert Lyon <email address hidden>
Date: Mon Feb 18 08:31:13 2019 +1300

Bug 1816311: Showing correct journal entry poster's name

When adding comment to the entry and the journal is owned by
group/institution

behatnotneeded

Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9578
Committed: https://git.mahara.org/mahara/mahara/commit/1261963a64292940029235f80d75d9e7f9552d9f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 1261963a64292940029235f80d75d9e7f9552d9f
Author: Robert Lyon <email address hidden>
Date: Mon Feb 18 08:31:13 2019 +1300

Bug 1816311: Showing correct journal entry poster's name

When adding comment to the entry and the journal is owned by
group/institution

behatnotneeded

Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243)

Reviewed: https://reviews.mahara.org/9579
Committed: https://git.mahara.org/mahara/mahara/commit/582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4
Author: Robert Lyon <email address hidden>
Date: Mon Feb 18 08:31:13 2019 +1300

Bug 1816311: Showing correct journal entry poster's name

When adding comment to the entry and the journal is owned by
group/institution

behatnotneeded

Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243)

Reviewed: https://reviews.mahara.org/9580
Committed: https://git.mahara.org/mahara/mahara/commit/bf174c60fc089c950074d1dd330b430300b05b19
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit bf174c60fc089c950074d1dd330b430300b05b19
Author: Robert Lyon <email address hidden>
Date: Mon Feb 18 08:31:13 2019 +1300

Bug 1816311: Showing correct journal entry poster's name

When adding comment to the entry and the journal is owned by
group/institution

behatnotneeded

Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243)
(cherry picked from commit 582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers