Consolidate "My friends" and "Find people" screens

[Kristina Hoeppner]

This is similar to bug #1813500.

1. The base template of "People" is "Find people" as it contains most of the functionality that we need. The new URL will be /people/index.php

2. To be added to that page: The filter options to filter for friends. The filter title is "Filter friends".

3. The "Search" filter options stay as they are.

4. When friend requests have been made, at the top on the right-hand side above "Send message", you see "Pending friend" and below that there are two buttons (the small size): "Approve" and "Deny" (with their respective current icon).

5. The main menu navigation item will be "People".

6. Consolidate the help icon text.

7. The "Help" link in the footer will need to change once I've updated the user manual.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9553

[Lisa Seeto (lisaseeto)]

After discussion with UX/Technical staff, "People" page will have only one search drop down that can accept queries. The filter list is "Everyone", Friends, Friend requests and "My institutions" (if applicable).

[Kristina Hoeppner (kris-hoeppner)]

The order of the items in the drop-down menu will be:
- Everyone
- My institutions
- Friends
- Friend requests

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Six users exist as follows
a) User1 Institution One friends with User2, User3, User4 Requested friends with User5, User6
b) User2 Institution One
c) User3 Institution One
d) User4 Institution One
e) User5 Institution One
f) User6 Institution Two

TEST STEPS:
------------------------
1) Log in as User1
2) Confirm there is a new sub menu item "People" found under Main menu > Engage
3) click the people menu item
4) Confirm the following
a) Page title is People ✔
b) URL is /people/index.php ✔
c) One search drop down that can accept the following queries ✔
      * Everyone ✔
      * My institutions (if applicable). ✔
      * Friends ✔
      * Friend requests ✔
      * Search parameter (ie name) ✔
d) Help icon and text when clicked will display ✔
      * Title = people ✔
      * help text = ✔
 This page lets you search for users to add as friends or simply to find their profile page.
 Depending on their friendship control settings, you may be automatically accepted as their
 friend or you may need to send a friendship request. Some users may not allow friendship
 requests at all.
 When sending a friendship request, you can choose to include a short message introducing
 yourself. This is especially important if you have a display name set as others will not see
 your real name.
 You can also see a list of your friends.
 A user can resubmit a friendship request to you, even if you have previously rejected that user.
5) Confirm the "Help" link in the footer links to the user manual. ✘
6) Confirm Search results are displayed as per the old Find people page ✔
7) Confirm Send friend request link is located above the Send message
8) Confirm When friend requests have been made, at the top on the right-hand side above "Send message", you see "Pending friend" and below that there are two buttons (the small size): "Approve" and "Deny" (with their respective current icon). ✔

NOTE: the "Help" link in the footer still needs to be linked to the correct page in the user manual. ✘

Catalyst QA Approved ✔

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Six users exist as follows
 a) User1 Institution One friends with User2, User3, User4 Requested friends with User5, User6
 b) User2 Institution One
 c) User3 Institution One
 d) User4 Institution One
 e) User5 Institution One
 f) User6 Institution Two

TEST STEPS:
------------------------
1) Log in as User1
2) Confirm there is a new sub menu item "People" found under Main menu > Engage
3) click the people menu item
4) Confirm the following
 a) Page title is People ✔
 b) URL is /people/index.php /user/index.php ✔
 c) One search drop down that can accept the following queries ✔
 * Everyone
 ✔
 * My institutions (if applicable).
 ✔
 * Friends
 ✔
 * Friend requests
 ✔
 * Search parameter (ie name)
 ✔
 d) Help icon and text when clicked will display ✔
    * Title = people
    * help text =
 This page lets you search for users to add as friends or simply to find their profile page.
 Depending on their friendship control settings, you may be automatically accepted as their
 friend or you may need to send a friendship request. Some users may not allow friendship
 requests at all.
 When sending a friendship request, you can choose to include a short message introducing
 yourself. This is especially important if you have a display name set as others will not see
 your real name.
 You can also see a list of your friends.
 A user can resubmit a friendship request to you, even if you have previously rejected that user.
5) Confirm the "Help" link in the footer links to the user manual.
6) Confirm Search results are displayed as per the old Find people page ✔
7) Confirm Send friend request link is located above the Send message ✔
8) Confirm When friend requests have been made, at the top on the right-hand side above "Send message", you see "Pending friend" and below that there are two buttons (the small size): "Approve" and "Deny" (with their respective current icon). ✔

NOTE:
1) the "Help" link in the footer still needs to be linked to the correct page in the user manual. - This will be done once manual has been updated ✔
2) URL is changed from /people/index.php to /user/index.php ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9553
Committed: https://git.mahara.org/mahara/mahara/commit/2b79e29a77aa35c8571586d4906eb617890cb336
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2b79e29a77aa35c8571586d4906eb617890cb336
Author: Lisa Seeto <email address hidden>
Date: Wed Feb 13 13:23:48 2019 +1300

Bug 1814621: Consolidate "My friends" and "Find people" screens

Change-Id: I4fc0334d50500d649e9f2c6125f0f181df0ccba4
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9682

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9682
Committed: https://git.mahara.org/mahara/mahara/commit/85e8d1bcf0f5411b417542c3a25aafa54e366666
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 85e8d1bcf0f5411b417542c3a25aafa54e366666
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Mar 29 15:15:30 2019 +1300

Bug 1814621: Updating steps in friends.feature

Change-Id: If122d14a6d64b83aea07d313c458710b4db7aca0