Old Mochikit function still in views.js for 17.10

Bug #1813862 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

Need to backport bug fix for https://bugs.launchpad.net/bugs/1801993
into 17.10

This old Mochikit function is breaking the "Add block" call when editing a page.
To test:
- Create a page and click on "Edit"
- Click on "Text" in the block menu
- Click on the "Add" button

Expected result: the block is added on the page
Actual result: the pop-up window is hidden but the block is not added to the page. There is also an error message in the js console of the browser

"ReferenceError: getViewportDimensions is not defined"

Changed in mahara:
status: New → Confirmed
status: Confirmed → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
assignee: Cecilia Vela Gurovic (ceciliavg) → nobody
status: In Progress → New
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9505

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9505
Committed: https://git.mahara.org/mahara/mahara/commit/6525e6b329f0dd867d373bcf3ba5723e147fad68
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 6525e6b329f0dd867d373bcf3ba5723e147fad68
Author: Robert Lyon <email address hidden>
Date: Wed Nov 7 07:47:31 2018 +1300

Bug 1813862: Remove old Mochikit function call

And replace it with equivalent jQuery call

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)
(cherry picked from commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef)

Robert Lyon (robertl-9)
Changed in mahara:
status: New → Fix Committed
milestone: none → 17.10.8
importance: Undecided → Medium
no longer affects: mahara/17.10
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.