Translation issues for forum unsubscribe link

[Kristina Hoeppner]

An issue has been encountered when translating "Unsubscribe from this %s".

The two possibilities are:

Unsubscribe from this forum
Unsubscribe from this topic

In German though the English "forum" / "topic" is inserted even though the normal %s is used in the translation even though both "forum" and "topic" have been translated.

These strings come up in /interaction/forum/lang/en.utf8/interaction.forum.php string forumposthtmltemplate

I can't figure out why the German translation wouldn't be shown for "forum" / "topic".

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9516

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Admin user is owner of Group1 and has created a forum with a topic
2) User1 exists and is a member of a Group1 and is subscribed to forum and notification settings are all set to email
3) User2 exists and is a member of a Group1 and is subscribed to forum and notification settings are all set to inbox
4) German language has been set to the site language default

TEST STEPS:
------------------------
1) Admin logs in
2) User browses to Group1 and creates a forum
3) User then creates a topic for the forum
4) Verify that user receives an email notification about the new topic ✔
5) Verify that the Unsubscribe from forum is displayed in German
*** a) Forum -> Diskussionsforum ✔
*** b) Topic -> Diskussionsthema ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9516
Committed: https://git.mahara.org/mahara/mahara/commit/ab554b34219b1df7246276e71d1111622c3d7491
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ab554b34219b1df7246276e71d1111622c3d7491
Author: Lisa Seeto <email address hidden>
Date: Fri Feb 1 12:47:30 2019 +1300

Bug 1813519: Translation issues for forum unsubscribe links

Added translation string for forumlower to lang file (english, de)
In lib.php where email message is made,
changed $user->subscribetype to explicityly
translate it with get_string_from_language func

behatnotneeded

Change-Id: I4551160b153c6a93bb455fa988bdafcd2f3e0606
Signed-off-by: Lisa Seeto <email address hidden>