Wall posts to other users not sending notification

Bug #1813200 reported by Robert Lyon on 2019-01-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.04
17.10
High
Unassigned
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Robert Lyon

Bug Description

When user A is leaving a wall post on another user B's profile page a notification is sent to user B

But after the first few messages the following bug occurs.

When posting to the wall the button switches from "Post" to "processing" - but doesn't finish processing.

On refresh of the page the new post exists.

So there is a problem with the process updating the page without reload.

Robert Lyon (robertl-9) on 2019-01-24
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 19.04.0
importance: Undecided → High
status: New → In Progress
Robert Lyon (robertl-9) wrote :

Turns out the problem is related to the information we give to the notification activity that happens after the new post is saved.

We accidentally supply the new wall post's id as the 'id' property in the activity $data class and the activity class confuses that id with an activity_type id.

So when the post id is a low number it can match with a real activity_type id and email is sent but in one's inbox it shows the wall post message with wrong activity type. They should all have the " icon - the circled one in attached image.

And when a wall post id is higher than any possible activity_type id then the 'processing...' error occurs.

We should strip out the wall post id from the object being sent to activity class

Robert Lyon (robertl-9) on 2019-01-24
tags: added: regression
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) 2 users exist (User A & User B)
2) Inbox notifications block on dashboard set to display 15 rows

TEST STEPS:
------------------------
1) User A logs in
2) Browses to User B profile page
3) User A posts a message on User B's wall
4) make 6 posts in a row to the wall
5) confirm that no delays or errors occur ✔
6) Log out and Log in as User B (should be on dashboard page after log in)
7) confirm Inbox block displays all 6 notifications "New post on your wall" ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9474
Committed: https://git.mahara.org/mahara/mahara/commit/3e733ce58b71c0474db4ca4e615d1ab029738f58
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3e733ce58b71c0474db4ca4e615d1ab029738f58
Author: Robert Lyon <email address hidden>
Date: Thu Jan 24 17:37:34 2019 +1300

Bug 1813200: Wallpost activity passing in confusing 'id' value

When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9501
Committed: https://git.mahara.org/mahara/mahara/commit/a468e253beb44f970656256539e920fc8a431a50
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit a468e253beb44f970656256539e920fc8a431a50
Author: Robert Lyon <email address hidden>
Date: Thu Jan 24 17:37:34 2019 +1300

Bug 1813200: Wallpost activity passing in confusing 'id' value

When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9502
Committed: https://git.mahara.org/mahara/mahara/commit/fd409baa4ff6c97d8b2c1be7dae26e354a611149
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit fd409baa4ff6c97d8b2c1be7dae26e354a611149
Author: Robert Lyon <email address hidden>
Date: Thu Jan 24 17:37:34 2019 +1300

Bug 1813200: Wallpost activity passing in confusing 'id' value

When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9503
Committed: https://git.mahara.org/mahara/mahara/commit/9edeab2641b59c18fa9d60ba26c5597f6d446024
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 9edeab2641b59c18fa9d60ba26c5597f6d446024
Author: Robert Lyon <email address hidden>
Date: Thu Jan 24 17:37:34 2019 +1300

Bug 1813200: Wallpost activity passing in confusing 'id' value

When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers