need to upgrade Font Awesome library from 4.7.0 to 5.X

Bug #1811904 reported by Cecilia Vela Gurovic on 2019-01-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Rebecca Blundell

Bug Description

need to upgrade Font Awesome library from 4.7.0 to 5.6.3

Changed in mahara:
status: New → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 19.04.0
importance: Undecided → Medium
Changed in mahara:
status: In Progress → Confirmed

There are a lot of changes from v4 to v5, it's not as simple as changing the lib files.

Mainly they ad a new css class to define is the icon is solid, light or regular, while in v4 it's part of the main icon class. They have also changed many icon names.

https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4

This upgrade is not a simple task and there are no security patches yet, I think we can leave it for 19.10

Changed in mahara:
milestone: 19.04.0 → none
Robert Lyon (robertl-9) on 2019-02-24
Changed in mahara:
milestone: none → 19.10.0
summary: - need to upgrade Font Awesome library from 4.7.0 to 5.6.3
+ need to upgrade Font Awesome library from 4.7.0 to 5.X
Changed in mahara:
assignee: Cecilia Vela Gurovic (ceciliavg) → Rebecca Blundell (rjb-dev)
status: Confirmed → In Progress
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9975

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9981

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9984

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9987

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9988

Changed in mahara:
importance: Medium → Wishlist
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9994

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10005

Rebecca Blundell (rjb-dev) wrote :

Notes for testing:

All of the icons on the site are now coming from the Fontawesome v5 library (https://fontawesome.com/icons?d=gallery).
This is tricky to test comprehensively as the icons really are present in all areas of the site.

To test:
1. First view the icons tab of the styleguide (mahara/theme/styleguide.php) in both master and the patch side by side. Look for missing icons in the patch and differences between master and the patch where the icon in the patch seems inverted or completely different to the master icon.

2. The icons have changed everywhere, so this is not an exhaustive list, but we should check some of the more specific cases where things needed to be updated:

Navigation:
Check all the menus contain corrects icons. (Note you may have to clear the caches on the admin overview page for the menu changes to take effect.)

Main Menu

Pages and Collections:
1. As well as the main icons, check the drop-down menu items from the cards.
2. Note that the block-chooser for a page is not currently displaying icons. This is not part of the test as it is being removed
3. Share a page with another user.
4. Log in as the other user and go to the page. Click on the 3 dots and then toggle the 'Add page to watchlist' option to confirm the icon flicks between eye and eye-slash.

Files:
1. Upload an image. Choose edit. Confirm the rotate icon appears.

Journals:
1. Confirm the calendar icons appear on journal entries.

Plans:
1. Checked boxes appear on completed items.
2. If you add the plan to a page block, an empty box appears on pending items.

People:
1. Check 'Remove from friends' icon is a person & x.

Groups:
1. Set up a group with these settings:
 Open - yes
 Recommendations - yes
 There need to be some site users who are not members of the group.
2. Log in as a user who is a member of the group and go to the group admin page. You should see a lightbulb icon on the 'Recommend to friends' button.
3. Compare this and the other icons on the page with a similar page on master.

Admin Menu

Institutions -> Legal
1. Add a couple of privacy statements.
2. Confirm that the most recent has a pencil and the others have an eye icon.

Extensions -> SmartEvidence
1. Follow the settings tab for a framework and check that the icons display correctly.
2. Add a framework to a collection.
3. Confirm that on the collection card drop-down there is a clipboard icon on the framework.
4. Add annotations to the framework and confirm the correct icons display on the module/framework/matrix page.

3. Finally click through the pages and look for anywhere icons are missing or seem wrong.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers