Updating mobile detect to 2.8.33

Bug #1811176 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Doing update of plugin

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 19.04.0
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9415

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User agent spoofer addon installed (set to android mobile)
2) Tester has developer tools to be able to see source code

TEST STEPS:
------------------------
1) Browse to page source code for the Mahara site
2) Verify the Script in the head of the page is displaying
<script type="application/javascript">
var config = {
'theme': [],
'sesskey' : 'WybtkNU3lgoYXHhF',
'wwwroot': 'https://master.dev.mahara.org/',
'loggedin': 1,
'userid': 1,
'mobile': 0,
'handheld_device': 1,
'cc_enabled': 0,
'mathjax': 0,
'select2_lang': ''
};
</script>
3) change the user agent spoofer to android mobile
4) Verify the Script in the head of the page is displaying
<script type="application/javascript">
var config = {
'theme': [],
'sesskey' : 'WybtkNU3lgoYXHhF',
'wwwroot': 'https://master.dev.mahara.org/',
'loggedin': 1,
'userid': 1,
'mobile': 1,
'handheld_device': 1,
'cc_enabled': 0,
'mathjax': 0,
'select2_lang': ''
};
</script>

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9415
Committed: https://git.mahara.org/mahara/mahara/commit/57556cf62e8b413d649d4f1fe216a8cf6c99a30c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 57556cf62e8b413d649d4f1fe216a8cf6c99a30c
Author: Robert Lyon <email address hidden>
Date: Thu Jan 10 15:08:43 2019 +1300

Bug 1811176: Updating mobile detect to 2.8.33

behatnotneeded

Change-Id: I9c98ec940b54bc52c6d793a7feb78d4dbe3be4df
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.