Peer assessment progress bar has some errors

Bug #1810862 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
18.10
Fix Released
High
Unassigned
19.04
Fix Released
High
Robert Lyon

Bug Description

When enabling the progress bar we can see the following problems:

1) expanding the 'Peer assessment' option shows the broken lang string [[placeassessment/artefact.peerassessment]]

2) when saving a value against peerassessment we get a broken site

These things need fixing up

And also we should also do progress for verification as well

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → High
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 19.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9398

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
------------------------
1) Configure site > Site options > user - Show profile completion is set to Yes
2) Institution user exists

Test Steps:
------------------------
1) Log in as SIte admin
2) Browse to Institution > Profile completion
3) Expand the Peer assessment section
4) Verify that the options are as follows
--- a) Place assessments label and a drop down box with selections from 0 (default) -> 5, 10, 15, 20, 25, 50, 100 ✔
--- b) Verify assessments label and a drop down box with selections from 0 (default) -> 5, 10, 15, 20, 25, 50, 100 ✔
5) Set the Place assessments drop down to 1
6) Set the Verify assessments drop down to 15
7) submit the form and log out
8) Log in as Institution user
9) Verify that the site does not break and user is on dashboard page ✔

Catalyst Qa Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9398
Committed: https://git.mahara.org/mahara/mahara/commit/1671f1f7383a265bc17996846ecdd06fff598968
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 1671f1f7383a265bc17996846ecdd06fff598968
Author: Robert Lyon <email address hidden>
Date: Tue Jan 8 11:07:45 2019 +1300

Bug 1810862: Get progress for peer assessment working

Fixes the problems with 'peerassesment' option and also adds the
'verify' option

behatnotneeded

Change-Id: I6492057738fa35b1de7262ee19621795ea10b0c3
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9575

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9575
Committed: https://git.mahara.org/mahara/mahara/commit/3f4202b61c9dc109171603df358f058dc8b82b73
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 3f4202b61c9dc109171603df358f058dc8b82b73
Author: Robert Lyon <email address hidden>
Date: Tue Jan 8 11:07:45 2019 +1300

Bug 1810862: Get progress for peer assessment working

Fixes the problems with 'peerassesment' option and also adds the
'verify' option

behatnotneeded

Change-Id: I6492057738fa35b1de7262ee19621795ea10b0c3
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.