Mahara webservice function get_groups_by_id_returns() fails if 'hidemembers' or 'hidemembersfrommembers' field is set to 'Hide tutors'

Bug #1804902 reported by Robert Lyon on 2018-11-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned

Bug Description

The 'hidemembers' and 'hidemembersfrommembers' fields used to be boolean (0 or 1 were valid) but were changed to be integer (0, 1, 2 are valid) but we forgot to update the webservice to allow for the new value '2'

Robert Lyon (robertl-9) wrote :

To test:

1) Set up a group where the 'Hide members' or 'Hide members from members' are set to 'Hide tutors'

2) Via the webservice testclient try and fetch the group by group id

Changed in mahara:
importance: Undecided → Medium
milestone: none → 19.04.0
status: New → In Progress
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
------------------------
1) User has to be Site admin + Institution admin + Group admin

Test Steps:
------------------------
1) Set up a group where the 'Hide members' or 'Hide members from members' are set to 'Hide tutors'
2) Via the webservice testclient try and fetch the group by group id
3) Verify Results do not have error messages (group data is returned) ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9331
Committed: https://git.mahara.org/mahara/mahara/commit/6523a7edcbca6752e28bbec6cd6808034c68143a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 6523a7edcbca6752e28bbec6cd6808034c68143a
Author: Robert Lyon <email address hidden>
Date: Sat Nov 24 13:48:11 2018 +1300

Bug 1804902: Allow for new option value in group webservices

For the 'hidemembers' and 'hidemembersfrommembers' webservice options

behatnotneeded

Change-Id: Ie2c400bd9e144a3ab369c0e6eeed5e6910c0b065
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers