Plan tasks are shown on timeline even when they didn't exist at the time

[Kristina Hoeppner]

New plan tasks appear in the timeline even when the tasks did not exist at the time of the snapshot.

To replicate:

1. Set up a plan with 2 task.
2. Add the plan to a page and save the page to the timeline.
3. Add another task to the plan.
(4. Save the new state to the timeline.)
Expected result: The third task does not appear in the first timeline item.
Actual result: All tasks are shown no matter the version of the portfolio page.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9389

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara User exists (no roles)
2) User Plan exists with 2 tasks
3) Portfolio page exists and has a Plan block
4) Portfolio page has been saved to a "Timeline" for the page

TEST STEPS:
------------------------
1) Log in as Mahara User
2) User add a task to the User plan
3) User browse to the Portfolio page with the plan block in display view
4) Verify that a 3rd task is displayed in the plan block ✔
5) Click the view time line
6) Verify that the page displayed only displays the first 2 task it has when saved to the timeline ✔

Catalyst QA Approved ✔

[Steven (stevens-q)]

Re-Test

1) Run the above script with a plan that has 10 tasks - save to time line
2) Then add another task

3) Verify that the 11th task does not display on the time line

Catalyst Qa Approved

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9389
Committed: https://git.mahara.org/mahara/mahara/commit/b829af50011cf7dc4250510f60beb58058d26348
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b829af50011cf7dc4250510f60beb58058d26348
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 28 13:22:16 2018 +1300

Bug 1804243: timeline: show correct version of a plan block

saves in version

for plans:
title
description
tags

for tasks:
task title
description
completion date
completed status(yes/no)
tags

behatnotneeded
Change-Id: Ib09cf4b8718f1180cb5f021bc532659db7f39647

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9717

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9717
Committed: https://git.mahara.org/mahara/mahara/commit/dcbc7ef214264ca128f3d51ef941ba32b33d021c
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit dcbc7ef214264ca128f3d51ef941ba32b33d021c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 28 13:22:16 2018 +1300

Bug 1804243: timeline: show correct version of a plan block

saves in version

for plans:
title
description
tags

for tasks:
task title
description
completion date
completed status(yes/no)
tags

behatnotneeded
Change-Id: Ib09cf4b8718f1180cb5f021bc532659db7f39647
(cherry picked from commit b829af50011cf7dc4250510f60beb58058d26348)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9718

[Robert Lyon (robertl-9)]

Cecilia, we will need an upgrade step to update the older version information so that existing plan versions have the correct 'existing_artefacts' configdata option

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9729

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9729
Committed: https://git.mahara.org/mahara/mahara/commit/7dd66f9c0715411e24fbbe9f2e69247eed759454
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7dd66f9c0715411e24fbbe9f2e69247eed759454
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 9 15:14:55 2019 +1200

Bug 1804243: timeline: upgrade 'plans' blocktype in versions

behatnotneeded

Change-Id: Ief0fe215ac5f376db4e09bbab7fa724e81bf1b36

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9735

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9735
Committed: https://git.mahara.org/mahara/mahara/commit/1149d87b978b4ff69599e9ee6d201819ac9a8f8e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 1149d87b978b4ff69599e9ee6d201819ac9a8f8e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 9 15:14:55 2019 +1200

Bug 1804243: timeline: upgrade 'plans' blocktype in versions

behatnotneeded

Change-Id: Ief0fe215ac5f376db4e09bbab7fa724e81bf1b36

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9736

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9737

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9736
Committed: https://git.mahara.org/mahara/mahara/commit/b35fe0fcedb814414ef2ed85e722e3a17072e8a2
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit b35fe0fcedb814414ef2ed85e722e3a17072e8a2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 9 15:14:55 2019 +1200

Bug 1804243: timeline: upgrade 'plans' blocktype in versions

behatnotneeded

Change-Id: Ief0fe215ac5f376db4e09bbab7fa724e81bf1b36

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9737
Committed: https://git.mahara.org/mahara/mahara/commit/054e54041c9f9f29fa9a78bd28fe6dd2685419db
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 054e54041c9f9f29fa9a78bd28fe6dd2685419db
Author: Robert Lyon <email address hidden>
Date: Wed Apr 10 15:54:41 2019 +1200

Bug 1804243: Adjust htdocs/view/createversion.php

Backporting change for creating version from
https://reviews.mahara.org/#/c/9615/

behatnotneeded

Change-Id: Ifa957f82ab250ab49d648fa081fbba107763b5cb
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9718
Committed: https://git.mahara.org/mahara/mahara/commit/6d33f81baee9acb37f2e157d05ab5c526b9a7ab7
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 6d33f81baee9acb37f2e157d05ab5c526b9a7ab7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 28 13:22:16 2018 +1300

Bug 1804243: timeline: show correct version of a plan block

saves in version

for plans:
title
description
tags

for tasks:
task title
description
completion date
completed status(yes/no)
tags

behatnotneeded
Change-Id: Ib09cf4b8718f1180cb5f021bc532659db7f39647
(cherry picked from commit b829af50011cf7dc4250510f60beb58058d26348)