need to refactor lib/htmloutput.php to use smarty templates

Bug #1802406 reported by Cecilia Vela Gurovic on 2018-11-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Unassigned

Bug Description

At the moment htmloutput.php is not using smarty templates. Instead, the code is full of html in strings and calls to php echo, which is not ideal.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 19.04.0
Changed in mahara:
importance: Low → Wishlist

Reviewed: https://reviews.mahara.org/9297
Committed: https://git.mahara.org/mahara/mahara/commit/e02653c34117ef71a908ef3191fe972cba426464
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e02653c34117ef71a908ef3191fe972cba426464
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5

Reviewed: https://reviews.mahara.org/9305
Committed: https://git.mahara.org/mahara/mahara/commit/cea4ffe05334cd8e631750eaaa22ca755efc0d96
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit cea4ffe05334cd8e631750eaaa22ca755efc0d96
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9306
Committed: https://git.mahara.org/mahara/mahara/commit/1613c886aea4a3efb584290d9c264e3ee00813c8
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 1613c886aea4a3efb584290d9c264e3ee00813c8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe05334cd8e631750eaaa22ca755efc0d96)

Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9307

Reviewed: https://reviews.mahara.org/9307
Committed: https://git.mahara.org/mahara/mahara/commit/4ab3cf830e74d144511ad0c22939b04b6bd82fcb
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 4ab3cf830e74d144511ad0c22939b04b6bd82fcb
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe05334cd8e631750eaaa22ca755efc0d96)
(cherry picked from commit 1613c886aea4a3efb584290d9c264e3ee00813c8)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers