Have a simplified group update webservice function

Bug #1802180 reported by Robert Lyon on 2018-11-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Robert Lyon

Bug Description

Currently the group_update() webservice function allow for changes to all group settings including making the group another type of group / changing who the members are.

This can be overkill if all one wants is to change the basic information about a group.

So I'll make a new group_update_details() webservice function to allow only the updating of:
- Group name
- Group description
- Group category

Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

1. Group exists (group ID = 1)
2. User has enabled web service functionality as follows
 --- a. Allow outgoing web service requests: Yes
 --- b. Accept incoming web service requests: Yes
 --- c. Protocol SOAP: = No
 --- d. Protocol XML-RPC: = Yes
--- e. Protocol REST: = Yes
--- f. Protocol OAuth: = Yes
3. Service group has been created and is is enabled and has user token access
4. The Functions for the service group are as follows
 --- a. mahara_group_create_groups
 --- b. mahara_group_get_groups_by_id
 --- c. mahara_group_update_groups_details
5. Service access token exists and is enabled for the service group

Test Steps:
1. Site admin user log in
2. Browse to Admin menu > Web services > Test client
3. Set the following fields to
 --- a. Protocol = Rest
 --- b. Authentication type = Token
 --- c. Service = <name of the service group mentioned in the Preconditions>
 --- d. Functions = <mahara_group_get_groups_by_id>
 --- e. ID = <ID of the existing group>
 --- f. wstoken = <name of the Service access token mentioned in the Preconditions>
 --- g. All other fields can be left as their default value
4. Click the execute button

Expected result: User should see a results pane with Json code - there should be no errors

Actual result: As expected

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9294
Committed: https://git.mahara.org/mahara/mahara/commit/5ab97a915da78814e7a9079aaa2bb8296996d54f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5ab97a915da78814e7a9079aaa2bb8296996d54f
Author: Robert Lyon <email address hidden>
Date: Thu Nov 8 10:13:13 2018 +1300

Bug 1802180: Have a simplified group update webservice option

Where it can only update some settings of the group and not allow it
to chage the group into another type nor change who are members


Change-Id: I262a8c0649b74bec146cfcce135b148fb1e0d790
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed

Thanks to Carleton University for this new feature.

tags: added: nominatedfeature

Reviewed: https://reviews.mahara.org/9321
Committed: https://git.mahara.org/mahara/mahara/commit/05aaf2c0082841fd6f1867d12fcdda2295c24733
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 05aaf2c0082841fd6f1867d12fcdda2295c24733
Author: Steven Spinelli <email address hidden>
Date: Tue Nov 20 12:05:52 2018 +1300

Behat Bug 1804074 Adding journal entry from Journal block on page
Merge branch 'master' of https://git.mahara.org/mahara/mahara

* 'master' of https://git.mahara.org/mahara/mahara:
Bug 1803616: SyntaxError: expected expression, got ';'
Bug 1802180: Have a simplified group update webservice option
Bug 1800422: Fixed z-index for custom-dropdown
Bug 1803194: Need to include the user object
Bug 1802205: All external links to be opened in new tab/window by default

Change-Id: Ibe0898d9326c0527cc6a4e937da9782b00c10eb0

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers