Old Mochikit function still in views.js

Bug #1801993 reported by Robert Lyon on 2018-11-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.04
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned

Bug Description

When we have the config setting $cfg->blockeditormaxwidth set to true

And go to add a block to a page we get an error -> "ReferenceError: getViewportDimensions is not defined"

This is due to the getViewportDimensions() function being an old MochiKit function.

We need to adjust this to get the needed value from a jQuery function

Robert Lyon (robertl-9) on 2018-11-06
Changed in mahara:
importance: Undecided → High
status: New → In Progress
milestone: none → 19.04.0
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
1) Set in cofig.php file: $cfg->blockeditormaxwidth = true;

Test Steps:
1) log in and add a text block to a portfolio page

Expected result: The text configure flyout modal from the right side of screen is displayed and the "Block content" editor window is approx 675 px in height (old height was approx 180)

Actual result: As Expected

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9287
Committed: https://git.mahara.org/mahara/mahara/commit/07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e
Author: Robert Lyon <email address hidden>
Date: Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9291
Committed: https://git.mahara.org/mahara/mahara/commit/e3fa699be8ca0970e0f776551afb2dc8e981c4ef
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef
Author: Robert Lyon <email address hidden>
Date: Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)

Reviewed: https://reviews.mahara.org/9292
Committed: https://git.mahara.org/mahara/mahara/commit/bc4c1e9f4322961e42cacea78cd87c4c54863efe
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit bc4c1e9f4322961e42cacea78cd87c4c54863efe
Author: Robert Lyon <email address hidden>
Date: Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)
(cherry picked from commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers