Institution tags can't be used on institution content

[Kristina Hoeppner]

When an admin sets up institution tags, they are not available when setting up institution pages or content for the institution. This will make it harder for people using the institution tags as the institution admin would want to use the official tags on templates that are copied to institution members.

When a copy is made, the tags needs to retain its institution tag quality.

1. Set up a couple of institution tags for an institution.
2. Create an institution page.
Expected result: You are able to choose from the available institution tags both as site admin and as institution admin. The site admin only sees the tags set up by the institution for which the content is created.
Actual result: The institution tags are not available.

Furthermore to test:
When a user copies an institution page that contains an institution tag, they are not able to edit that tag and it counts towards the use of the institution tag on Admin menu -> Institutions -> Tags.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9577

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Institution exists
2) Institution admin exists
3) A couple of institution tags for an institution exist created by Institution admin
4) A couple of institution tags for an institution exist created by Site admin
5) Institution pages with tags have "Allow copying" set to Yes (default is No) and the page is shared with Institution

TEST STEPS:
------------------------
1) Log in as site admin
2) Create an institution page.
3) Confirm the site admin only sees the tags set up by the institution for which the content is created ✔
4) Confirm an institution page with tags are not able editable and it counts towards the use of the institution tag on Admin menu -> Institutions -> Tags ✔

Catalyst QA Approved ✔

[Steven (stevens-q)]

TITLE: Tags used when setting up an Institution page are shortened

BUG SUMMARY: When an Institution or Site admin have created an Institution page and go back to edit the tags, the tags have been shortened to 3 characters and also display the number of times used

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) The following Institutions exist
   a) Institution One
   b) Institution Two
2) Institution Tags are enabled (found on inst settings page) for both Institutions
3) The following Institution tags for Institution One exist
   a) Institution One: Inst1tag - created by Inst admin for Inst One
   b) Institution One: INST-ONE - created by Inst admin for Inst One
   c) Institution One: SA-INST1 - created by Site admin for Inst One
4) Institution tag " Inst2tag" for Institution Two exists
5) Inst admin for Institution One exists

TEST STEPS:
------------------------
1) Log in as Inst admin
2) create an institution page for Institution One
3) Verify that all Inst tags for Inst One are able to be selected ✔
4) Select the top one in the list of Inst tags field and save page
5) Go back to the settings page and add another Inst tag

Expected Result: All of the institution tags should be available to be selected in the tags field for the page stettings

Actual Result: The tags have been shortened to 3 characters and also display the number of times used, User can add another tag which will be displayed correcly. If user again saves and goes back to edit the tags, the latest tags selected will also be shortened to 3 characters and also display the number of times used

[Steven (stevens-q)]

TITLE: Site admin cannot add Inst tags to block content on inst page

BUG SUMMARY:
1) When a Site admin creates an Institution page, they are able to select all of the Institution tags that have been created.
2) When Site admin adds content blocks to a page, they are only able to select tags that have been used when they created a the site page

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) The following Institutions exist
a) Institution One
b) Institution Two
2) Institution Tags are enabled (found on inst settings page) for both Institutions
3) The following Institution tags for Institution One exist
a) Institution One: Inst1tag - created by Inst admin for Inst One
b) Institution One: INST-ONE - created by Inst admin for Inst One
c) Institution One: SA-INST1 - created by Site admin for Inst One
4) Institution tag " Inst2tag" for Institution Two exists
5) Inst admin for Institution One exists

TEST STEPS:
------------------------
1) Log in as Site admin
2) create an institution page for Institution One
3) Verify that all Inst tags for Inst One are able to be selected ✔
4) Select the top one in the list of Inst tags field and save page
5) Add a text block on the page

Expected Result: All of the institution tags should be available to be selected in the tags field for the text block

Actual Result: Only one tag was able to be selected - (the same tag I used when I created the page)

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) The following Institutions exist
a) Institution One
b) Institution Two
2) Institution Tags are enabled (found on inst settings page) for both Institutions
3) The following Institution tags for Institution One exist
a) Institution One: Inst1tag - created by Inst admin for Inst One
b) Institution One: INST-ONE - created by Inst admin for Inst One
c) Institution One: SA-INST1 - created by Site admin for Inst One
4) Institution tag " Inst2tag" for Institution Two exists
5) Inst admin for Institution One exists

TEST STEPS:
------------------------
1) Log in as Site admin
2) create an institution page for Institution One
3) Verify that all Inst tags for Inst One are able to be selected ✔
4) Select the top one in the list of Inst tags field and save page
5) Edit the page settings
6) Select the top one in the list of Inst tags field

Expected Result: User should not be able to select the same tag that has been previously used

Actual Result: Selecting the same tag will display another tag within the tags field, User can repeatedly use the same tags and each tag will be displayed

[Steven (stevens-q)]

All Bugs have been fixed

1) Site admin and Institution admin are able to create inst tags and mahatra user (no role) can select all institution tags
2) All of the institution tags should be available to be selected in the tags field for the page stetting
3) adding the same tag a second time will delete the tag

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9577
Committed: https://git.mahara.org/mahara/mahara/commit/1fa6bfc59cdaa1d7895619ee3bae062cf5edfd11
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1fa6bfc59cdaa1d7895619ee3bae062cf5edfd11
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Feb 18 17:04:56 2019 +1300

Bug 1800321: Use institution tags in institution content

behatnotneeded

Change-Id: I26ebb888908a8be5ba96057920f73c5507e3bbc9

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9765

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9765
Committed: https://git.mahara.org/mahara/mahara/commit/d946010e2ff55ba6dd276e629178517fc687787e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d946010e2ff55ba6dd276e629178517fc687787e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Feb 18 17:04:56 2019 +1300

Bug 1800321: Use institution tags in institution content

behatnotneeded

Change-Id: I26ebb888908a8be5ba96057920f73c5507e3bbc9
(cherry picked from commit 1fa6bfc59cdaa1d7895619ee3bae062cf5edfd11)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9766

[Steven (stevens-q)]

Using the above test cases and verifying bugs fixed on 18.10 stable - working as expected

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9766
Committed: https://git.mahara.org/mahara/mahara/commit/2bec90d037b91da2aa214784f800eb9d1b8dc99a
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 2bec90d037b91da2aa214784f800eb9d1b8dc99a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Feb 18 17:04:56 2019 +1300

Bug 1800321: Use institution tags in institution content

behatnotneeded

Change-Id: I26ebb888908a8be5ba96057920f73c5507e3bbc9
(cherry picked from commit 1fa6bfc59cdaa1d7895619ee3bae062cf5edfd11)
(cherry picked from commit d946010e2ff55ba6dd276e629178517fc687787e)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9776