Cookie Consent links to privacy.php instead of legal.php

[Kristina Hoeppner]

In Mahara 18.04, when Cookie Consent is turned on, the "Learn more" link links to privacy.php rather than legal.php.

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9276

[Steven (stevens-q)]

Summary: Verified bug using 18.04 with no patch -> loaded patch - never seen popup with learn more link - warning and log messages displayed at top of page

Steps to recreate
--------------------
1. Switched to Mahara 18.04
2. cherry picked patch
3. Browse to Admin menu > Cookie consent
4. Enable Cookie Consent to yes

Expected Result: Popup displayed at bottom of page with "Learn more" link. Clicking link takes user to links to privacy.php rather than legal.php.

Actual Result: Conformation message displayed top of page, warning message (see attached screenshot) Popup not displayed at bottom of page

[Steven (stevens-q)]

Bug Fixed - Note - had to run CLI make css after changing to an earlier version of Mahara for it to work

Popup displayed at bottom of page with "Learn more" link. Clicking link takes user to links to privacy.php rather than legal.php. ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9276
Committed: https://git.mahara.org/mahara/mahara/commit/6a11cccd9c649245fac81af681ff9d7178bca2cc
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 6a11cccd9c649245fac81af681ff9d7178bca2cc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Nov 1 08:22:01 2018 +1300

Bug 1800315: cookie consent "Learn more" to redirect to legal.php

behatnotneeded

Change-Id: I0c556a00bfec585dfc6a561ff7f66d9fd7fc7410