View site statistics has error if there are no blocks

[Rebecca Blundell]

If you install a new site and go to http://mahara/admin/users/statistics.php when there are no blocks saved, you see

"Invalid argument supplied for foreach()", "~/code/mahara/htdocs/lib/stati...", 210, array(size 18)) at ~code/mahara/htdocs/lib/statistics.php:210, referer: http://mahara/admin/index.php

There is an invalid argument in this case as the value of $blocktypecounts is false and the code says:
foreach ($blocktypecounts as $blocktype) {
...get the details...
}
We should put it in an if statement to avoid the error.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9273

[Kristina Hoeppner (kris-hoeppner)]

It will need to be checked if the issue also occurs in Mahara 18.04 and 17.10.