View approved pending users

Bug #1798981 reported by Ralph Ballier on 2018-10-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Robert Lyon

Bug Description

It should be possible to provide a list of those who have registered and have been approved by the admin but have not yet provided their username and password, so to speak, have not yet replied.

True - I notice that on the Admin -> Pending registrations page it only shows the users that have not been approved yet.

But once you approve them they are not listed any more but nor are they fully members listed on the Admin -> Users search page as there is a final step needed by user - to follow the complete signup link in email.

I've added a patch that allows the Admin -> Pending registrations page to also list those that are approved but yet not completed

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 19.04.0
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9) on 2018-10-25
Changed in mahara:
importance: Medium → Wishlist

We can't keep them forever though due to privacy. Also, once the 24-hour registration time frame is up, their link won't work anymore and they'll have to start from scratch again.

Ralph Ballier (raba) wrote :

I had not thought about the validity of 24 hours. Could you maybe raise to 48 hours?

No matter: in any case, you no longer need to expect an unexpected and unnoticed registration much later.

You can raise the limit yourself in the code to 48 hours. Typically, a one-time key is not kept for a long period of time and 24 hours is already that so that it can't be misused.

summary: - Special list of users
+ View approved pending users
Steven (stevens-q) wrote :

*Environment tested:* Master
*Browser tested:* Chrome

*Preconditions:*
> 1. Institution exists & Registration allowed = yes

*Test Steps:*
> 1. Browse to Mahara site home page (login page)
> 2. Click the register link
> 3. Fill in all required fields and submit registration
> 4. Log into site as Site admin
> 5. Browse to Admin menu > Institutions > Pending registrations page

*Expected result:*
1. expiry date column added to show admin when they will disappear ✔
2. Text to right of date "Approval sent, waiting on user completion not actioned" ✔
3. The user should be deleted from the system after expiry date ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9267
Committed: https://git.mahara.org/mahara/mahara/commit/83cdeb6c072378793eaf794c37279526488e1534
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 83cdeb6c072378793eaf794c37279526488e1534
Author: Robert Lyon <email address hidden>
Date: Thu Oct 25 13:14:07 2018 +1300

Bug 1798981: Show approved registrations waiting on user completion

On the Admin -> Pending registrations page
Also added the expiry date to show admin when they will disappear if
not actioned
Also updated the text to make it a bit clearer about what is happening
when

behatnotneeded

Change-Id: Icb33def34fa79c41438d58a50e9e139da6a950cb
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2018-11-01
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers