Do not link tags in HTML export

Bug #1798720 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Doris Tam

Bug Description

Tags in the HTML export link back to the original site. The links should be removed as it can't be expected that the original site is still available.

tags: added: export
Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9356

Doris Tam (doristam)
Changed in mahara:
status: Confirmed → In Progress
Changed in mahara:
milestone: none → 19.04.0
Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
------------------------
1. Portfolio page exists with the following:
--- a. Text Block with links to (external link, internal page link) - (tags = Text, Text1)
--- b. Image Block - (image tag = Sheep, Farm)
--- c. Plan Block - (User plans that have a task with tag = plan, task)
--- a. Journal Block - (User Journal that have a Entries with tag = journal, entry)
--- d. Tagged Journal Entries Block
--- e. Folder Blocks
--- f. Image Gallery Blocks
--- g. PDF Block
--- h. Navigation Block (that has pages with the above blocks and tags)

Test Steps:
------------------------
1. Log in as an authenticated user that has a portfolio page as mentioned above
2. Export the page as Standalone HTML website
3. Save the zip file to a local folder and extract the contents
4. Open the index.html file in the folder
5. Verify that all of the "tag" links are displayed as plain text ✔
6. Verify that all "Details" links are not displayed ✘
7. Verify that any block titles do not link back to original site (ie Journal entry block titles) ✘
8. Verify that tags used for "Tagged Journal entry" blocks are displayed as plain text ✔
9. Verify that Images, files,PDF's, and other exported files do not link to original site (should link to folder that comes in the zip file) ✘

Catalyst QA Failed Testing ✘

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Items 7 and 9 needs to be dealt with separately. That is not part of this feature. There is already a bug report for that.

Why shall "Details" links not be displayed? We'd need in order to see details about particular artefact I would think.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Any tags, i.e. usually prefixed by "Tags" should not be links anymore. Other links may still go to live sites. That is behavior that is not fixed here, but is a separate issue.

Changed in mahara:
milestone: 19.04.0 → 19.10.0
Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 10fd48dc4585770be27a22e7aff7026f227b0d2f
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Mahara User1 exists (no roles0
2) Mahara User1 has a plan with tasks and a Journal with published journal entries
3) Mahara User1 has a folder with images all tagged test
4) Portfolio page exists with the following:
  a) Text Block with links to (external link, internal page link) - (tags = Text, Text1)
  b) Image Block - (image tag = Sheep, Farm)
  c) Plan Block - (User plans that have a task with tag = plan, task)
  a) Journal Block - (User Journal that have a Entries with tag = journal, entry)
  d) Tagged Journal Entries Block
  e) Folder Blocks
  f) Image Gallery Blocks
  g) PDF Block
  h) Navigation Block (that has pages with the above blocks and tags)

TEST STEPS:
------------------------
1) Log in as Mahara User1
2) Export the page as Standalone HTML website
3) Save the zip file to a local folder and extract the contents
4) Open the index.html file in the folder
5) Verify that all of the "tag" links are displayed as plain text ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9356
Committed: https://git.mahara.org/mahara/mahara/commit/0bd2fb3452ed19b62fef5f9e5e1d8805892df627
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0bd2fb3452ed19b62fef5f9e5e1d8805892df627
Author: Doris Tam <email address hidden>
Date: Wed Dec 5 15:11:54 2018 +1300

Bug 1798720: Replacing the active tag link for static text in the export.

Parses the link for the tag and returns captured plain text in replace.

behatnotneeded

Change-Id: Idfe8f28a52f024576d431091da24f784c10d5e9d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.