Forms that use progress bar when saving now do not show progress bar

Bug #1796600 reported by Robert Lyon on 2018-10-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

When saving on view access screen there is a "sendjsonrequest() failed: error" in the browser console

This is because of the following problems:

1) The saving of the access does a check to see if we should display the progress meter bar
 - it does this on any save - yet the progress meter is only meant for the saving when 'copy page to existing users' when saving a group page

2) The form saves in a non-js form way yet the ajax call to the progress meter needs to be done is a jsfrom way - otherwise the brwoser goes to new page an ajax fails before result is returned

What is needed is get the access form to save as a jsform and then to only use the progress meter if doing copy page event

Robert Lyon (robertl-9) on 2018-10-08
summary: - Saving group page to existing users system causing error
+ Forms that use progress bar when saving now do not show progress bar
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
------------------------
1. Site Admin user exists

Test Steps:
------------------------
1. Log in as Site admin
2. Create 100 user by csv
3. Verify that the progress bar is displayed ✔
4. Create 25 new groups
Verify that the progress bar is displayed ✔
6. Add the 100 users to the 25 new groups
Verify that the progress bar is displayed ✔
8. create a group page and share with all members in the group
9. Verify that the progress bar is displayed ✔

NOTES:
1. Progress bar is displayed as expected - suggest throttle network so that the displayed progress bar is not displayed in the blink of an eye.
2. Progress bar is not styled - most of the time the bar was a solid white background colour
3. I ran the above scenario a few times on a fresh DB - sometimes I would see the coloured progress bar but mostly not - just white background

Steven (stevens-q) wrote :

Re-Test

Environment tested: Master
Browser tested: Chrome

Preconditions:
------------------------
1. Site Admin user exists

Test Steps:
------------------------
1. Log in as Site admin
2. Create 100 user by csv
3. Verify that the progress bar is displayed and styled correctly ✔
4. Create 25 new groups
Verify that the progress bar is displayed and styled correctly ✔
6. Add the 100 users to the 25 new groups
Verify that the progress bar is displayed and styled correctly ✔
8. create a group page and share with all members in the group
9. Verify that the progress bar is displayed and styled correctly ✔

NOTES:
1. Progress bar is displayed as expected - suggest throttle network so that the displayed progress bar is not displayed in the blink of an eye.

Steven (stevens-q) wrote :

Re-Test

Environment tested: Master
Browser tested: Chrome

Still working as expected see previous comment.

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9205
Committed: https://git.mahara.org/mahara/mahara/commit/080e4c2b3df0784f00cbfa26644ff20b069e2a16
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 080e4c2b3df0784f00cbfa26644ff20b069e2a16
Author: Robert Lyon <email address hidden>
Date: Mon Oct 8 13:25:24 2018 +1300

Bug 1796600: Getting progress meter to display again

Getting it to flow more smoothly as well

Note: does not fix copy page to existing group members as that form
breaks horible when submitting as js

behatnotneeded

Change-Id: Icbf437990ae06fc717199b6735007d9dcb2c885a
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers