Portfolio access report should indicate portfolios that are under review

[Kristina Hoeppner]

In Mahara 18.10 we introduced the functionality to revoke access to a portfolio by an administrator when it is objectionable. The "Portfolio under review" string is displayed on "Shared by me", but not in the "Portfolio access" report that an administrator can see.

It would be good to also mention it in the report in the access column because that is the initial page where an admin would look why someone can't access a portfolio.

To replicate:

1. Create a portfolio as User A and share it with registered users.
2. Report the portfolio as objectionable by User B.
3. Click the "Still objectionable" button as site admin and remove access to the portfolio.
4. As site admin, go to Admin menu -> Reports -> Configure report -> Portfolio access and view the list (set the date to tomorrow to get all current portfolios).
Expected result: The message: "Portfolio under review; access was revoked" is displayed for the portfolio whose access was revoked. This could be the row in red like under "Shared by me".
Actual result: No message and the admin can't see from this screen that access had been revoked.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9244

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9244
Committed: https://git.mahara.org/mahara/mahara/commit/5252f8f064e18cb9bc1890fee0835c92c397056c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5252f8f064e18cb9bc1890fee0835c92c397056c
Author: Liam <email address hidden>
Date: Fri Oct 19 16:54:05 2018 +1300

Bug #1796525: Portfolio access report should indicate portfolios that are under review

behatnotneeded

Change-Id: Ic438d8cd00047e708f3846921cfeb2e644703392