Can't export portfolio with french translation

Bug #1794990 reported by Guillaume Colson on 2018-09-28
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 18.10
17.10
High
Unassigned
18.04
High
Unassigned
18.10
High
Cecilia Vela Gurovic
19.04
High
Unassigned

Bug Description

Mahara version : 18.04.2
french langPack : 18.04

A problem in french translation generate a JS error when trying to export a portfolio (export/index.php).
You need to modify the string that is inserted in the JS to escape the quote.

You need to modify the file fr.utf8/lang/fr.utf8/export.php

$string['exportgeneratedsuccessfully1'] = 'L\'export a été généré avec succès.';

become
$string['exportgeneratedsuccessfully1'] = 'L\\\'export a été généré avec succès.';

Sorry if this is not the right place to put this but I couldn't find a better place.

Hi Guillaume,

Thank you for the suggestion of fixing this. I changed it in the French translation pack at https://translations.launchpad.net/mahara-lang/trunk/+pots/mahara/fr/+translate By having it changed in "trunk" it is also changed in the other versions.

You are welcome to make changes to the translations there directly yourself when you notice a problem.

Your change should be propagated through to the language pack that you can download from https://langpacks.mahara.org sometime tomorrow after Launchpad made the export file. Please give it a go then.

Changed in mahara:
status: New → Fix Committed
importance: Undecided → High
Cmathieu (cmathieu) wrote :

Hi,
apparently, the problem is not fixed. We have just updated today the FR langpack, and the version doesn't contain your fix.

In the 18.04.3 version of the langpack, the translation is $string['exportgeneratedsuccessfully1'] = 'L\'export a été généré avec succès.';
In the 18.10 (and master_fr) version of the langpack, the translation is $string['exportgeneratedsuccessfully1'] = 'L\\\\\\\'export a été généré avec succès.';
There is 7 \ !!

Thanks

I fixed it up again. I didn't see 7 backslashes, but definitely more than should be in there. We'll have to check, once the export has been made, if things are shown correctly now.

As mentioned before, you can always fix language strings yourself at https://translations.launchpad.net/mahara-lang Usually, they are put into the export branch once a day and then available via langpacks.mahara.org

Changed in mahara:
status: Fix Committed → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 19.04.0

Reviewed: https://reviews.mahara.org/9297
Committed: https://git.mahara.org/mahara/mahara/commit/e02653c34117ef71a908ef3191fe972cba426464
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e02653c34117ef71a908ef3191fe972cba426464
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5

Reviewed: https://reviews.mahara.org/9305
Committed: https://git.mahara.org/mahara/mahara/commit/cea4ffe05334cd8e631750eaaa22ca755efc0d96
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit cea4ffe05334cd8e631750eaaa22ca755efc0d96
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5

Reviewed: https://reviews.mahara.org/9306
Committed: https://git.mahara.org/mahara/mahara/commit/1613c886aea4a3efb584290d9c264e3ee00813c8
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 1613c886aea4a3efb584290d9c264e3ee00813c8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe05334cd8e631750eaaa22ca755efc0d96)

Reviewed: https://reviews.mahara.org/9307
Committed: https://git.mahara.org/mahara/mahara/commit/4ab3cf830e74d144511ad0c22939b04b6bd82fcb
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 4ab3cf830e74d144511ad0c22939b04b6bd82fcb
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 9 11:27:42 2018 +1300

Bug 1794990: prevent echo call from removing escape character

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe05334cd8e631750eaaa22ca755efc0d96)
(cherry picked from commit 1613c886aea4a3efb584290d9c264e3ee00813c8)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers