Need to tidy up Mahara so that it better reflects the W3C standards

Bug #1794912 reported by Robert Lyon on 2018-09-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

Running a page through https://validator.w3.org/ shows that there are HTML issues that we should cleanup

How to test:

1. Go to the validator and the tab "Validate by Direct Input".
2. Copy and paste the entire page source of the Mahara page you'd like to run through.

Expected result: No warnings or errors.
Actual result: Lot of warning and some errors. The warning are esp. around Javascript as the notation changed for it.

Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Tester to use W3C standards validator page
2. Pages tested have some content created (not just a blank page)

Test Steps:
1. Browse to the following pages
a. Home page - while logged out ✔
b. Dashboard page ✔
c. Portfolio page with content on it ✔
d. Site options page ✘
e. User profile page ✔
f. Files page ✔

Expected result: No warnings or errors.

Steven (stevens-q) wrote :

Re-Test
---------------
Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Tester to use W3C standards validator page
2. Pages tested have some content created (not just a blank page)

Test Steps:
1. Browse to the following pages
a. Home page - while logged out ✔
b. Dashboard page ✔
c. Portfolio page with content on it ✔
d. Site options page ✘
e. User profile page ✔
f. Files page ✔
g. Introduction Resume page ✘
h. Education and employment | Résumé ✘
i. Goals and skills | Résumé ✘

Steven (stevens-q) wrote :

Bugs fixed for the following pages Site options page, Introduction Resume page, Education and employment | Résumé, Goals and skills | Résumé

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/9118
Committed: https://git.mahara.org/mahara/mahara/commit/e858c0328cacf2faa234c9b7c32e3cbabfe9c4b1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e858c0328cacf2faa234c9b7c32e3cbabfe9c4b1
Author: Robert Lyon <email address hidden>
Date: Fri Sep 7 14:23:18 2018 +1200

Bug 1794912: Fixing W3.org validation issues

W3 speicifications have changed and Mahara code didn't pass the
validator. Issues have been corrected.

behatnotneeded

Change-Id: Ic22cc7cd6df0bddc995ff7f61502a2aa7455810c
Signed-off-by: Robert Lyon <email address hidden>

Steven (stevens-q) wrote :

Title: Bug 1794912 Fixing W3.org validation issues for iframes

Bug Summary: Running a page through https://validator.w3.org/ shows that there are HTML issues that we should cleanup

===========================================

Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Authenticated user exists
2. Portfolio page with external video block exists (iframe)

Test Steps:
1. User log in
2. Browse to page with external media block
3. select all the source code for the page
4. run the code through W3 validation here https://validator.w3.org/#validate_by_input

Actual result: Error message "Error: Bad value 1 for attribute allowfullscreen on element iframe."

Expected result: No Error messages

Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Authenticated user exists
2. Portfolio page with external video block exists (iframe)

Test Steps:
1. User log in
2. Browse to page with external media block
3. select all the source code for the page
4. run the code through W3 validation here https://validator.w3.org/#validate_by_input

Actual result:

1. Bug Fixed - I no longer see Error message "Error: Bad value 1 for attribute allowfullscreen on element iframe."
2. I see 2 new bugs - see screenshot attached

Expected result: No Error messages

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9263
Committed: https://git.mahara.org/mahara/mahara/commit/baab8c177f68fc58093fc1622e9ffe9ed10d6f61
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit baab8c177f68fc58093fc1622e9ffe9ed10d6f61
Author: Robert Lyon <email address hidden>
Date: Wed Oct 24 14:24:32 2018 +1300

Bug 1794912: Fixing W3.org validation issues for iframes

behatnotneeded

Change-Id: If8b9eabe97ebc9cd0a272b7bb4bc60b08685c56f
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2018-11-07
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.