Block change watchlist notification not displaying correct owner

Bug #1794370 reported by Robert Lyon on 2018-09-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Unassigned
18.10
High
Robert Lyon

Bug Description

Scenario:

A watched page has it's blocks changed (added/modified/deleted) and this causes a watchlist notification to be generated.

Problem:

The message in the watchlist notification 'The page "%s" belonging to %s has been changed' can becoume incorrect under the following circumstance - if the person triggering the 'watchlist_record_changes' event is not the page owner then their name is displayed as the 'belonging to %s' part.

This is incorrect and it should show the page owner instead.

Robert Lyon (robertl-9) on 2018-09-25
Changed in mahara:
status: New → Confirmed
status: Confirmed → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 18.10.0

Reviewed: https://reviews.mahara.org/9144
Committed: https://git.mahara.org/mahara/mahara/commit/0866ac938ff6d973c14b8238ab8109f6a87440f0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 0866ac938ff6d973c14b8238ab8109f6a87440f0
Author: Robert Lyon <email address hidden>
Date: Wed Sep 26 08:59:21 2018 +1200

Bug 1794370: Use correct owner for watchlist message

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/9149
Committed: https://git.mahara.org/mahara/mahara/commit/c4d2b5fe6e365bdf9cd72efc0009ac7506f80d36
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit c4d2b5fe6e365bdf9cd72efc0009ac7506f80d36
Author: Robert Lyon <email address hidden>
Date: Wed Sep 26 08:59:21 2018 +1200

Bug 1794370: Use correct owner for watchlist message

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0866ac938ff6d973c14b8238ab8109f6a87440f0)

Reviewed: https://reviews.mahara.org/9150
Committed: https://git.mahara.org/mahara/mahara/commit/d67773e5705f08abbb84e18849460d97ea8d4488
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit d67773e5705f08abbb84e18849460d97ea8d4488
Author: Robert Lyon <email address hidden>
Date: Wed Sep 26 08:59:21 2018 +1200

Bug 1794370: Use correct owner for watchlist message

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0866ac938ff6d973c14b8238ab8109f6a87440f0)

Reviewed: https://reviews.mahara.org/9151
Committed: https://git.mahara.org/mahara/mahara/commit/10267404f2bb2652c5ec9de496f0221dc12d13e5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 10267404f2bb2652c5ec9de496f0221dc12d13e5
Author: Robert Lyon <email address hidden>
Date: Wed Sep 26 08:59:21 2018 +1200

Bug 1794370: Use correct owner for watchlist message

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0866ac938ff6d973c14b8238ab8109f6a87440f0)
(cherry picked from commit d67773e5705f08abbb84e18849460d97ea8d4488)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers