PDF.js does not have the presentation mode option in Firefox and IE

Bug #1778792 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Lisa Seeto

Bug Description

https://mahara.org/interaction/forum/topic.php?id=8303

When you embed a PDF into a page, the presentation mode option is only available in Chrome and Opera but not in Firefox and IE though according to the PDF.js website demo https://mozilla.github.io/pdf.js/ Firefox should be able to use the presentation mode.

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Changed in mahara:
assignee: Rebecca Blundell (rjb-dev) → nobody
milestone: 18.10.0 → 19.04.0
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9620

Revision history for this message
Lisa Seeto (lisaseeto) wrote :

Looks like it was missing an attribute to allow full screen mode display in the iframe.
I've added it in now.

https://www.w3.org/TR/html5/embedded-content-0.html#the-iframe-element

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome, Firefox and IE 11

PRECONDITIONS:
------------------------
1) PDF file exists
2) User exists and has a Portfilio page (site admin)
2) Portfolio page exists and has a PDF block
3) Browsers to test with - Chrome, Firefox and IE 11

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to the Portfolio page with a PDF block
3) Click the Presentation mode link in the PDF viewer on the page
4) Verify that the PDF is now displayed as full screen and clicking Esc on keyboard will return screen to normal page ✔
5) Verify the above step works for the following browsers ✔
   a) Chrome ✔
   b) Firefox ✔
   c) Internet Explorer v. 11 ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9620
Committed: https://git.mahara.org/mahara/mahara/commit/97ad9af73a417315069596a679bdde3926f312a6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 97ad9af73a417315069596a679bdde3926f312a6
Author: Lisa Seeto <email address hidden>
Date: Tue Mar 12 15:59:52 2019 +1300

Bug 1778792: PDF.js does not have the presentation mode option in Firefox and IE

Added allowfullscreen attr to iframe for pdf

behatnotneeded

Change-Id: If21c2766225d5b7d86d2ebc019fefa039e787d3d
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.