user statistics sendjasonrequest error

[Cecilia Vela Gurovic]

in admin/users/statistics.php, just loading the page will make a few errors show in the browsers console.

sendjsonrequest() callback failed:
ReferenceError
​
columnNumber: 133
​
fileName: "http://maharatest/js/chartjs/Chart.min.js?v=8242 line 10 > Function"
​
lineNumber: 3
​
message: "datasets is not defined"
​
stack: "anonymous@http://maharatest/js/chartjs/Chart.min.js?v=8242 line 10 > Function:3:133\ne@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:5200\ns.template@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:5260\ngenerateLegend@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:11904\nfetch_graph_data/<@http://maharatest/js/mahara.js?v=8242:922:38\nsendjsonrequest/<@http://maharatest/js/mahara.js?v=8242:362:17\ni@http://maharatest/js/jquery/jquery.js?v=8242:2:27060\nadd@http://maharatest/js/jquery/jquery.js?v=8242:2:27364\nsendjsonrequest@http://maharatest/js/mahara.js?v=8242:345:5\nfetch_graph_data@http://maharatest/js/mahara.js?v=8242:903:5\n@http://maharatest/admin/users/statistics.php:455:13\ni@http://maharatest/js/jquery/jquery.js?v=8242:2:27060\nfireWith@http://maharatest/js/jquery/jquery.js?v=8242:2:27828\nready@http://maharatest/js/jquery/jquery.js?v=8242:2:29619\nJ@http://maharatest/js/jquery/jquery.js?v=8242:2:29804\n"
​

[Robert Lyon (robertl-9)]

If I remember right this is a race condition problem as the datasets does get defined and graph does display correctly

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8981

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

-------------------------------------
Manual Test Script
-------------------------------------

Preconditions:

1. Database must have a few users, institutions, content etc (to be able to see a report)

Test Script - Site admin runs Information overview report and checks to see graphs have a legend

1. Site admin logged in
2. Browse to Admin menu > Reports
3. User should see "Information overview | All institutions" title
4. Confirm the circular graphs are displayed with corresponding legends ✔
5. Confirm the line graph is displayed with corresponding legend ✔
6. Open the developer toolbar to view the colsole and refresh the page
7. Confirm there are no errors displayed ✔

[BUG] the graph legends are sometimes displayed correctly and upon a hard
refresh the graph legends may fall outside the containing box or display
over top of other page text. see attached screen shot. refreshing the page
after a hard reset will often correct the display error.

[Steven (stevens-q)]

Bug Fixed - the graph legends are now displaying correctly after hard refresh and refresh of the Overview report page.

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8981
Committed: https://git.mahara.org/mahara/mahara/commit/d09994c2b7df4a30f8336a5f55638767f9607f87
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit d09994c2b7df4a30f8336a5f55638767f9607f87
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 29 13:01:33 2018 +1200

Bug 1778451: Show legend in charts

Use correct variable in template when creating the legend for charts.

In Chart.js legendTemplate uses var 'datasets'
or 'segments' depending on the type of charts
type Doughnut/PolarArea/Pie use segments
type Line/Radar/Bar use datasets

We have to check which one is defined in the Chart object before
modifying the legend template

Also delayed the updating of page by .5 secs so not to clash with
chart jsons stuff

behatnotneeded

Change-Id: Id3ef35a5037ac2c30d342279e0af7052584f7d16

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8999

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8999
Committed: https://git.mahara.org/mahara/mahara/commit/c07156122d6dc32a2bb398635b1cd0b04521b101
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit c07156122d6dc32a2bb398635b1cd0b04521b101
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 29 13:01:33 2018 +1200

Bug 1778451: Show legend in charts

Use correct variable in template when creating the legend for charts.

In Chart.js legendTemplate uses var 'datasets'
or 'segments' depending on the type of charts
type Doughnut/PolarArea/Pie use segments
type Line/Radar/Bar use datasets

We have to check which one is defined in the Chart object before
modifying the legend template

Also delayed the updating of page by .5 secs so not to clash with
chart jsons stuff

behatnotneeded

Change-Id: Id3ef35a5037ac2c30d342279e0af7052584f7d16
(cherry picked from commit d09994c2b7df4a30f8336a5f55638767f9607f87)

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9000

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9000
Committed: https://git.mahara.org/mahara/mahara/commit/7b9303eb875ed46b8f9d32c80aac032ef30d88b2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 7b9303eb875ed46b8f9d32c80aac032ef30d88b2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 29 13:01:33 2018 +1200

Bug 1778451: Show legend in charts

Use correct variable in template when creating the legend for charts.

In Chart.js legendTemplate uses var 'datasets'
or 'segments' depending on the type of charts
type Doughnut/PolarArea/Pie use segments
type Line/Radar/Bar use datasets

We have to check which one is defined in the Chart object before
modifying the legend template

Also delayed the updating of page by .5 secs so not to clash with
chart jsons stuff

behatnotneeded

Change-Id: Id3ef35a5037ac2c30d342279e0af7052584f7d16
(cherry picked from commit d09994c2b7df4a30f8336a5f55638767f9607f87)
(cherry picked from commit c07156122d6dc32a2bb398635b1cd0b04521b101)

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/9001

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9001
Committed: https://git.mahara.org/mahara/mahara/commit/118984ac6d5d0bae3500fd1c739d5730c4e34d6a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 118984ac6d5d0bae3500fd1c739d5730c4e34d6a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Jul 10 10:21:34 2018 +1200

Bug 1778451: Show legend in charts

Use correct variable in template when creating the legend for charts.

In Chart.js legendTemplate uses var 'datasets'
or 'segments' depending on the type of charts
 type Doughnut/PolarArea/Pie use segments
 type Line/Radar/Bar use datasets

We have to check which one is defined in the Chart object
before modifying the legend template

behatnotneeded

Change-Id: I3185616d5ffde2378c092c59c78c01503d01e6ae

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8981
Committed: https://git.mahara.org/mahara/mahara/commit/d09994c2b7df4a30f8336a5f55638767f9607f87
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d09994c2b7df4a30f8336a5f55638767f9607f87
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 29 13:01:33 2018 +1200

Bug 1778451: Show legend in charts

Use correct variable in template when creating the legend for charts.

In Chart.js legendTemplate uses var 'datasets'
or 'segments' depending on the type of charts
type Doughnut/PolarArea/Pie use segments
type Line/Radar/Bar use datasets

We have to check which one is defined in the Chart object before
modifying the legend template

Also delayed the updating of page by .5 secs so not to clash with
chart jsons stuff

behatnotneeded

Change-Id: Id3ef35a5037ac2c30d342279e0af7052584f7d16