jquery-ui timepicker- old code needs to be removed
Bug #1777971 reported by
Cecilia Vela Gurovic
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Invalid
|
Medium
|
Lisa Seeto |
Bug Description
when upgrading jquery-ui to 1.12.1 I found a customization in the file
jquery-
* Added call to function after datepicker arrow key is pressed - to
allow the year arrows to be re-added on day change
that was added in commit
here, a function add_prev_
that function was removed in commit 8d796e7ca04b6df
for Bug #1744191: Updated the datepicker to use the bootstrap one
there is no need to add extra code to jquery-ui.min.js
and it would be good to check what else is in the code but not needed anymore
Changed in mahara: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
milestone: | none → 18.10.0 |
tags: | added: code-cleanup |
Changed in mahara: | |
milestone: | 18.10.0 → 19.04.0 |
Changed in mahara: | |
assignee: | nobody → Lisa Seeto (lisaseeto) |
Changed in mahara: | |
milestone: | 19.04.0 → 19.10.0 |
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
status: | In Progress → Invalid |
Changed in mahara: | |
milestone: | 19.10.0 → none |
To post a comment you must log in.
I gone over the previous commits to the file:
1st: b5a7abd380a12e6 b97304f35c24250 17ff4d34a4 9a7d1b0eb8d145c 8f94cd50fb e57c1408d2c6326 fd04c5985e
2nd: 00e96e99c0c7515
3rd: cccb223aed4e34d
It seems that the only custom change to jquery- ui/js/jquery- ui.min. js came in on the 2nd commit and was subsequently removed. The only modifications to the file have been version upgrades.