Remove obsolete code for displaying comments
Bug #1775479 reported by
Cecilia Vela Gurovic
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Rebecca Blundell |
Bug Description
We have old code not used anymore for displaying comment list from a text note
in view/view.php ln 308
It was added in commit e03327b0f68d6c7
for
"Adjusting the textbox so it can show/hide comments (Bug #1037531)
The comments will be displayed (or hidden) below the block by clicking
on the 'Comments (x)' link. There is also a 'close' link at the bottom
of the comment list as well to close them."
We don't use this anymore since now, when clicking on coment(x) link, they are displayed in a right side modal panel.
We have to check what other obsolete related code we need to clean.
Changed in mahara: | |
milestone: | none → 18.10.0 |
no longer affects: | mahara/17.04 |
no longer affects: | mahara/17.10 |
no longer affects: | mahara/18.04 |
Changed in mahara: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Rebecca Blundell (rjb-dev) |
tags: | added: code-cleanup |
Changed in mahara: | |
milestone: | 18.10.0 → 19.04.0 |
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
milestone: | 19.04.0 → 19.10.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
summary: |
- obsolete code for displaying comments + Remove obsolete code for displaying comments |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Plizz unsubscribe me from the domain. This is not what my school wanted to
join for my e -Portifolio
Michael Singini
On Sun, 15 Jul 2018 at 03:10, Kristina Hoeppner <email address hidden>
wrote:
> ** No longer affects: mahara/17.04 /bugs.launchpad .net/bugs/ 1775479 bc40cd04cfed441 f42b802ba3 in /bugs.launchpad .net/mahara/ +bug/1775479/ +subscriptions
>
> ** No longer affects: mahara/17.10
>
> ** No longer affects: mahara/18.04
>
> ** Changed in: mahara
> Status: New => Confirmed
>
> ** Changed in: mahara
> Importance: Undecided => Medium
>
> ** Changed in: mahara
> Assignee: (unassigned) => Rebecca Blundell (rjb-dev)
>
> --
> You received this bug notification because you are subscribed to Mahara
> 18.04.3.
> https:/
>
> Title:
> obsolete code for displaying comments
>
> Status in Mahara:
> Confirmed
>
> Bug description:
> We have old code not used anymore for displaying comment list from a
> text note
> in view/view.php ln 308
>
> It was added in commit e03327b0f68d6c7
> 15.04
>
> for
> "Adjusting the textbox so it can show/hide comments (Bug #1037531)
>
> The comments will be displayed (or hidden) below the block by
> clicking
> on the 'Comments (x)' link. There is also a 'close' link at the
> bottom
> of the comment list as well to close them."
>
> We don't use this anymore since now, when clicking on coment(x) link,
> they are displayed in a right side modal panel.
>
> We have to check what other obsolete related code we need to clean.
>
> To manage notifications about this bug go to:
> https:/
>