Remove obsolete code for displaying comments

Bug #1775479 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Rebecca Blundell

Bug Description

We have old code not used anymore for displaying comment list from a text note
in view/view.php ln 308

It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in 15.04

for
  "Adjusting the textbox so it can show/hide comments (Bug #1037531)

    The comments will be displayed (or hidden) below the block by clicking
    on the 'Comments (x)' link. There is also a 'close' link at the bottom
    of the comment list as well to close them."

We don't use this anymore since now, when clicking on coment(x) link, they are displayed in a right side modal panel.

We have to check what other obsolete related code we need to clean.

Tags: code-cleanup
Changed in mahara:
milestone: none → 18.10.0
no longer affects: mahara/17.04
no longer affects: mahara/17.10
no longer affects: mahara/18.04
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Rebecca Blundell (rjb-dev)
Revision history for this message
Michael Singini (michaelsingini1) wrote : Re: [Bug 1775479] Re: obsolete code for displaying comments

Plizz unsubscribe me from the domain. This is not what my school wanted to
join for my e -Portifolio

Michael Singini

On Sun, 15 Jul 2018 at 03:10, Kristina Hoeppner <email address hidden>
wrote:

> ** No longer affects: mahara/17.04
>
> ** No longer affects: mahara/17.10
>
> ** No longer affects: mahara/18.04
>
> ** Changed in: mahara
> Status: New => Confirmed
>
> ** Changed in: mahara
> Importance: Undecided => Medium
>
> ** Changed in: mahara
> Assignee: (unassigned) => Rebecca Blundell (rjb-dev)
>
> --
> You received this bug notification because you are subscribed to Mahara
> 18.04.3.
> https://bugs.launchpad.net/bugs/1775479
>
> Title:
> obsolete code for displaying comments
>
> Status in Mahara:
> Confirmed
>
> Bug description:
> We have old code not used anymore for displaying comment list from a
> text note
> in view/view.php ln 308
>
> It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in
> 15.04
>
> for
> "Adjusting the textbox so it can show/hide comments (Bug #1037531)
>
> The comments will be displayed (or hidden) below the block by
> clicking
> on the 'Comments (x)' link. There is also a 'close' link at the
> bottom
> of the comment list as well to close them."
>
> We don't use this anymore since now, when clicking on coment(x) link,
> they are displayed in a right side modal panel.
>
> We have to check what other obsolete related code we need to clean.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions
>

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote : Re: obsolete code for displaying comments

Micheal, I sent you an email. You can unsubscribe yourself. If you have any problems, please let me know via email.

tags: added: code-cleanup
Changed in mahara:
milestone: 18.10.0 → 19.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9602

Changed in mahara:
status: Confirmed → In Progress
Changed in mahara:
milestone: 19.04.0 → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9602
Committed: https://git.mahara.org/mahara/mahara/commit/3611725eb8a7a897bb228a4dd6ba0f0cd39ad4c1
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3611725eb8a7a897bb228a4dd6ba0f0cd39ad4c1
Author: Rebecca Blundell <email address hidden>
Date: Wed Feb 27 12:15:55 2019 +1300

Bug 1775479: remove obsolete comment code

remove some un-needed code
can't find anything else that should go

behatnotneeded

Change-Id: I25f978739640a895bd54ea1d9781bc537db4b029

Changed in mahara:
status: In Progress → Fix Committed
summary: - obsolete code for displaying comments
+ Remove obsolete code for displaying comments
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.