Upgrade 3rd party plugin Dwoo for php 7.2

Bug #1773892 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Rebecca Blundell

Bug Description

related to https://bugs.launchpad.net/mahara/+bug/1752743

We're currently using Dwoo 1.2.0. Dwoo 1.3.7 looks at first glance like it fixes php 7.2-related things, but the latest changelog is for version 1.3.6 (Mar 2017), so that's not clear. We need to confirm all the deprecated functions have been removed and then look at upgrading.

http://www.dwoo.org/
https://github.com/dwoo-project/dwoo

Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8978

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8978
Committed: https://git.mahara.org/mahara/mahara/commit/3f821e53b3eb475b207524971f8a0e38736da7a7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3f821e53b3eb475b207524971f8a0e38736da7a7
Author: Rebecca Blundell <email address hidden>
Date: Thu Jun 28 14:52:01 2018 +1200

Bug 1773892: Upgrade Dwoo for PHP 7.2

Upgraded to 1.3.7

Issues:

Needed to change calls to class names to not use underscores
Changed calls to the Dwoo/$dwoo class to Core/$core
discovered that wrong file path wass being called for the dataroot
changes to use namespaces instead of requires
Changed Mahara plugins to camelcase naming.

Dwoo now uses composer to autoload files and
composer needs to cache the paths to classes before Dwoo will run.

behatnotneeded

Change-Id: Ia6b7f41c96fe5695a1ed94476e21eca5a9f1c9ee

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.