Upgrade 3rd party plugin CSSTidy for php 7.2

Bug #1773891 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Rebecca Blundell

Bug Description

related to https://bugs.launchpad.net/mahara/+bug/1752743

CSSTidy is currently at version 1.5.5, 1.5.7 looks like it replaces functions deprecated in php 7.2, although I haven't comprehensively checked it and the github page is not specific, just says it has changes for php 7.0.

https://github.com/Cerdic/CSSTidy

Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8976

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

-------------------------------------
Manual Test Script
-------------------------------------

Preconditions:

1. Institution member "InstAMember" exists
2. User created skin exists as follows:
----- a. Skin title = Some Skin name
----- b. Custom CSS = p {display:block;color:#639;font-size:11px}

Test Script: User creates portfolio page and uses "Some Skin name" skin to give page text a purple colour

1. User creates a portfolio page as follows:
----- a. Page title = Skins testing CSSTidy
----- b. Skins = Some Skin name
2. User adds a text block to the page
3. User click "Display page" button
4. Confirm that the text colour of the text block is indeed purple ✔

Catalyst QA Approved ✔

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8976
Committed: https://git.mahara.org/mahara/mahara/commit/79bac249ca16cb650582a3a8c426bfaf6ce61fe9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 79bac249ca16cb650582a3a8c426bfaf6ce61fe9
Author: Rebecca Blundell <email address hidden>
Date: Tue Jun 26 16:23:30 2018 +1200

Bug 1773891: Update csstidy to 1.5.7

includes compatibility changes for PHP 7.2

behatnotneeded

Change-Id: Ifd0b988cd513bd327ea7cf08b434788916f150b9

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.