Need to call render_items in the static way

Bug #1772773 reported by Robert Lyon on 2018-05-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Cecilia Vela Gurovic
17.10
High
Cecilia Vela Gurovic
18.04
High
Cecilia Vela Gurovic

Bug Description

There is this error reported by a forum member

error(2048, "Non-static method PluginBlocktypeMyviews::render_i...", "/var/www/mahara1804/blocktype/myviews/lib.php", 109, array(size 8)) at /var/www/mahara1804/blocktype/myviews/lib.php:109

See https://mahara.org/interaction/forum/topic.php?id=8260&post=33051

Looking at the places we use render_items() they are not called in a static way

(unlike calls to render_instance() )

Robert Lyon (robertl-9) on 2018-05-23
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
importance: Medium → High
milestone: none → 18.10.0
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/8880
Committed: https://git.mahara.org/mahara/mahara/commit/00ed9a98c74002c1ccdd9a902c3aafef19d439e9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 00ed9a98c74002c1ccdd9a902c3aafef19d439e9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 14:17:01 2018 +1200

Bug 1772773: call render_items in the static way

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88

Robert Lyon (robertl-9) on 2018-05-24
Changed in mahara:
status: In Progress → Fix Committed
Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8885

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8886

Reviewed: https://reviews.mahara.org/8885
Committed: https://git.mahara.org/mahara/mahara/commit/68f0ec8cf4676eff2f52f58ce1e1aa0cd66c7886
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 68f0ec8cf4676eff2f52f58ce1e1aa0cd66c7886
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 14:17:01 2018 +1200

Bug 1772773: call render_items in the static way

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88
(cherry picked from commit 00ed9a98c74002c1ccdd9a902c3aafef19d439e9)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8886
Committed: https://git.mahara.org/mahara/mahara/commit/495056b9fe1e3d1c57fd3ab625ba0b2c5076890f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 495056b9fe1e3d1c57fd3ab625ba0b2c5076890f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 14:17:01 2018 +1200

Bug 1772773: call render_items in the static way

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88
(cherry picked from commit 00ed9a98c74002c1ccdd9a902c3aafef19d439e9)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8884
Committed: https://git.mahara.org/mahara/mahara/commit/3785fcaa9b6a041a82042b7d53ce3b55f6468157
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 3785fcaa9b6a041a82042b7d53ce3b55f6468157
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 14:17:01 2018 +1200

Bug 1772773: call render_items in the static way

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88
(cherry picked from commit 00ed9a98c74002c1ccdd9a902c3aafef19d439e9)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers