No sorting of tags according to "date" when clicked on a tag

Bug #1771473 reported by Cyle Sprick on 2018-05-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Cecilia Vela Gurovic
17.04
Medium
Cecilia Vela Gurovic
17.10
Medium
Cecilia Vela Gurovic
18.04
Medium
Cecilia Vela Gurovic
18.10
Medium
Cecilia Vela Gurovic

Bug Description

A user reported that they were unable to sort tags using the "Date" link on the tags page. This problem seems to be resolved when entering the tags page via clicking on the word 'tags', but exists when getting to the tags page by clicking on one of his tags in the tag cloud.

To reproduce the bug, click on a tag in the tag cloud and then try to sort the list of artefacts by clicking on the 'date' link at the top of the list. Changing to another tag from the tag list at this point will show the same non-sorting behaviour.

Proper behaviour is seen when entering the tags page via the word 'tag' at the top of the cloud and then clicking on one of the tags in the list to filter to that tag.

This is on 17.10

Thanks for having reported this problem, Cyle.

This also happens when you click on a tag in a page: The date sorting does not work.

tags: removed: date sort
summary: - different behaviour of tags page depending on entry
+ No sorting of tags according to "date" when clicked on tag in the tag
+ cloud
summary: - No sorting of tags according to "date" when clicked on tag in the tag
- cloud
+ No sorting of tags according to "date" when clicked on a tag

Could not replicate for master.
For 18.04, 17.10, 17.04 it only breaks when I get to tags.php through opening a view and clicking on one of its tags.

One thing I noted in the list of items with a tag, the views and collections show the date but the artefacts don't show it anymore. I'm not sure if this is something we want, we showed it in previous versions.

Note for testers:
When ordering by Date the views, collections and artefacts are order by the date they were created.

no longer affects: mahara/18.10
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome
===================
Manual Test Script
===================

Preconditions:
1. User has Tags on the following:
a. Files
b. Images
c. Text
d. Pages
e. Collections
2. Tags are created on various date/times
3. There are more than 20 Articles (files, images, text and pages) with tags
4. There are more than 15 articles associated with one tag

Test Steps: Click Tags Block heading
1. User log in
2. User browse to Main menu > Protfolio > Pages and collections
3. Confirm that the Tags block is displayed in right hand side of page ✔
4. Click the "Tags" heading of the block
5. Confirm that the user is redirected to the My Tags page ✔
6. Click the Date link (top right of tags table)
7. Confirm that the tags in the table are sorted by date ✔
8. click page 2 of the table pagination (bottom of table)
9. Confirm that the second page is also sorted by date ✘

Test Steps: Click Tags Block heading
1. User log in
2. User browse to Main menu > Protfolio > Pages and collections
3. Confirm that the Tags block is displayed in right hand side of page ✔
4. Click a tag name in the block
5. Confirm that the user is redirected to the My Tags page ✔
6. Click the Date link (top right of tags table)
7. Confirm that the tags in the table are sorted by date ✔
8. click page 2 of the table pagination (bottom of table)
9. Confirm that the second page is also sorted by date ✔

BUG: Tags are not sorted by date on second page of the tags table

When the following conditions are met:
1. When user has got to the
"My Tags" page by clicking the "Tags" heading of the block on Pages and collections page
2. When there is pagination on the "My Tags" page (at least 2 pages)
3. user has sorted by date

Expected result: all tags in table are sorted by date including tags on 2nd page of table etc.

Note: is working when user navigates to "My Tags" page by clicking a tags within the block

Changed in mahara:
milestone: none → 18.04.1
no longer affects: mahara/18.04
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8895

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8902

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8903

Reviewed: https://reviews.mahara.org/8903
Committed: https://git.mahara.org/mahara/mahara/commit/65696c0fdd59c17ed30a82e6d4f7a4a9ce15f26e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 65696c0fdd59c17ed30a82e6d4f7a4a9ce15f26e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 29 12:57:47 2018 +1200

Bug 1771473: tags search - filter and sort selectors update each other

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8895
Committed: https://git.mahara.org/mahara/mahara/commit/6853aed4ab372b6ff884f7145d58b2300ede72b7
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 6853aed4ab372b6ff884f7145d58b2300ede72b7
Author: Robert Lyon <email address hidden>
Date: Fri May 25 16:24:46 2018 +1200

Bug 1771473: Confusion of sorting

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8910

Reviewed: https://reviews.mahara.org/8910
Committed: https://git.mahara.org/mahara/mahara/commit/c51162a0afc12ed42159ce0d5284ad87f5ef01f7
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit c51162a0afc12ed42159ce0d5284ad87f5ef01f7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 29 12:57:47 2018 +1200

Bug 1771473: tags search - filter and sort selectors update each other

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8909
Committed: https://git.mahara.org/mahara/mahara/commit/9818f19c273072c885df7099bfd4211ac7c2721a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 9818f19c273072c885df7099bfd4211ac7c2721a
Author: Robert Lyon <email address hidden>
Date: Fri May 25 16:24:46 2018 +1200

Bug 1771473: Confusion of sorting

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8912

Reviewed: https://reviews.mahara.org/8911
Committed: https://git.mahara.org/mahara/mahara/commit/e250e696eb260ba7d0523435851702423d59401b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit e250e696eb260ba7d0523435851702423d59401b
Author: Robert Lyon <email address hidden>
Date: Fri May 25 16:24:46 2018 +1200

Bug 1771473: Confusion of sorting

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9818f19c273072c885df7099bfd4211ac7c2721a)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8912
Committed: https://git.mahara.org/mahara/mahara/commit/5ccb86a63504184233560354d643c0bd3c136095
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 5ccb86a63504184233560354d643c0bd3c136095
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 29 12:57:47 2018 +1200

Bug 1771473: tags search - filter and sort selectors update each other

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45
(cherry picked from commit c51162a0afc12ed42159ce0d5284ad87f5ef01f7)

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8914

Reviewed: https://reviews.mahara.org/8914
Committed: https://git.mahara.org/mahara/mahara/commit/689fd6ca441ac59232d0ee1f6a88154d8e593e5c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 689fd6ca441ac59232d0ee1f6a88154d8e593e5c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 29 12:57:47 2018 +1200

Bug 1771473: tags search - filter and sort selectors update each other

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45
(cherry picked from commit c51162a0afc12ed42159ce0d5284ad87f5ef01f7)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8913
Committed: https://git.mahara.org/mahara/mahara/commit/5e911ec74ad617a78a2d1e3d547ca963e79c29b4
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 5e911ec74ad617a78a2d1e3d547ca963e79c29b4
Author: Robert Lyon <email address hidden>
Date: Fri May 25 16:24:46 2018 +1200

Bug 1771473: Confusion of sorting

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9818f19c273072c885df7099bfd4211ac7c2721a)
(cherry picked from commit e250e696eb260ba7d0523435851702423d59401b)

Steven (stevens-q) wrote :

BUG Fixed: Tags are now sorted by date on second page of the tags table ✔

When the following conditions are met:
1. When user browse to the
----"My Tags" page by clicking the "Tags" heading of the block on Pages and collections page
2. When there is pagination on the "My Tags" page (at least 2 pages)
3. user has sorted by date

Expected result: all tags in table are sorted by date including tags on 2nd page of table etc. ✔

Catalyst QA Approved ✔

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8878
Committed: https://git.mahara.org/mahara/mahara/commit/e0093956f43e8f613aa1599a7ece3d47314282b5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit e0093956f43e8f613aa1599a7ece3d47314282b5
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 08:56:58 2018 +1200

Bug 1771473: sorting of tags according to "date" when clicked on a tag

a few changes copied from patch https://reviews.mahara.org/#/c/8607
(whishlist for 18.10)

to fix 18.04

behatnotneeded

Change-Id: I8a6d64601005c708c11e719f94254c43e8fb2833

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8916

Reviewed: https://reviews.mahara.org/8916
Committed: https://git.mahara.org/mahara/mahara/commit/52d26910db46321f185ec2624910eb03a52560ea
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 52d26910db46321f185ec2624910eb03a52560ea
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 08:56:58 2018 +1200

Bug 1771473: sorting of tags according to "date" when clicked on a tag

a few changes copied from patch https://reviews.mahara.org/#/c/8607
(whishlist for 18.10)

to fix 18.04

behatnotneeded

Change-Id: I8a6d64601005c708c11e719f94254c43e8fb2833
(cherry picked from commit e0093956f43e8f613aa1599a7ece3d47314282b5)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8915
Committed: https://git.mahara.org/mahara/mahara/commit/ce3c530a2f7bca39166f28cb136e9900cd7189c3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit ce3c530a2f7bca39166f28cb136e9900cd7189c3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 23 08:56:58 2018 +1200

Bug 1771473: sorting of tags according to "date" when clicked on a tag

a few changes copied from patch https://reviews.mahara.org/#/c/8607
(whishlist for 18.10)

to fix 18.04

behatnotneeded

Change-Id: I8a6d64601005c708c11e719f94254c43e8fb2833
(cherry picked from commit e0093956f43e8f613aa1599a7ece3d47314282b5)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers